List:Internals« Previous MessageNext Message »
From:Padraig O'Sullivan Date:October 15 2010 4:21pm
Subject:Re: Query Rewriting Plugin
View as plain text  
Hi Lenz,

On Thu, Oct 14, 2010 at 11:54 AM, Lenz Grimmer <lenz.grimmer@stripped> wrote:
> Hi Padraig,
> On 10/13/10 23:25, Padraig O'Sullivan wrote:
>>>> I have my work in a branch on launchpad
>>>> (lp:~posulliv/mysql-server/query-rewrite) but I'm not familiar with
>>>> the procedure to get code considered for MySQL. I'm wondering what is
>>>> the preferred method to have this patch considered? Should I propose
>>>> the branch for merging on launchpad or should I send a patch to this
>>>> mailing list?
>>>> Any pointers to the procedure I should follow would be awesome.
>>> Here:
>> Cool, thanks. I sent a copy of the SCA to the email address listed on
>> that page today. After I hear back from them, should I just send a
>> patch to the list?
> Thanks for turning in the SCA, I've reviewed and approved it. Keeping your
> work in a BZR branch is likely the best approach, plain patches are a bit
> cumbersome to handle and tend to bit-rot quickly...
> It would not harm to also create a related bug report, marked as a "feature
> request". That makes it easier to track the contribution (see the Wiki page
> for instructions).
> Unfortunately I can not comment on the patch itself, I leave this to the
> developers subscribed to this list. But from an administrative point of view,
> your patch is good to go :)

I created bug #57459 as a feature request for this. I also updated the
plugin based on feedback from Sergei. I added a new plugin point which
allows a query rewrite plugin to work on the parse tree instead of the
raw query text.

This means a query rewrite plugin developer could either choose to
work on the raw query text or the parse tree produced by MySQL.
Personally, its easier for me to work on the raw query text right now
then to figure out how to correctly modify the MySQL parse tree. I
think its nice to allow a plugin developer to choose which they would
like to work with.

I proposed the branch for merging on Launchpad as well this morning.


>    Lenz
> --
> Lenz Grimmer | MySQL Community Relations Specialist EMEA
> Phone: +49 40 41267308 | Mobile: +49 172 7106443
> ORACLE Deutschland B.V. & Co. KG -
> Hauptverwaltung: Riesstr. 25, D-80992 München
> Registergericht: Amtsgericht München, HRA 95603
> Komplementärin: ORACLE Deutschland Verwaltung B.V.
> Rijnzathe 6, 3454PV De Meern, Niederlande
> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
> Geschaftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven
> Oracle is committed to developing practices and products that help
> protect the environment -
Query Rewriting PluginPadraig O'Sullivan13 Oct
  • Re: Query Rewriting PluginSergei Golubchik13 Oct
    • Re: Query Rewriting PluginPadraig O'Sullivan13 Oct
      • Re: Query Rewriting PluginPeter Benjamin Volk13 Oct
      • Re: Query Rewriting PluginSergei Golubchik14 Oct
      • Re: Query Rewriting PluginLenz Grimmer14 Oct
        • Re: Query Rewriting PluginPadraig O'Sullivan15 Oct