> -----Original Message-----
> From: MARK CALLAGHAN [mailto:mdcallag@stripped]
> Sent: Wednesday, February 04, 2009 2:46 PM
> To: Ivan Novick
> Cc: internals@stripped
> Subject: Re: innodb_flush_method
> Innodb calls fsync in os_file_flush() which does not reference
> UNIV_DO_FLUSH. os_file_flush() is called from fil_flush to try to
> fsync. Whether fsync is done is determined by the value of the my.cnf
> parameter innodb_flush_method and os_file_flush() looks at variables
> derived from that to figure out what to do.
Yeah but the calls to os_file_flush in both os_file_pwrite and os_file_write
are surrounded by #ifdef UNIV_DO_FLUSH
It seems that these are the 2 most standard cases of calling os_file_flush
and they are essentially dead code due to the UNIV_DO_FLUSH
Is it right?