List:Internals« Previous MessageNext Message »
From:pem Date:October 5 2005 3:15pm
Subject:bk commit into 5.0 tree (pem:1.2016) BUG#13616
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of pem. When pem does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2016 05/10/05 16:39:37 pem@stripped +1 -0
  Fixed BUG#13616: "CALL <dbname>.<procedurename>" executes properly, but
                   displays error
      When returning to the old database (which may be ""), don't do
      access check - mysql_change_db() would then generate the error
      "No database selected".
      Note: No test case added; it seems a db is always selected when running
      tests.

  sql/sp_head.cc
    1.189 05/10/05 16:39:30 pem@stripped +3 -1
    Don't do access check when returning to db after a call.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	pem
# Host:	mysql.comhem.se
# Root:	/usr/home/pem/mysql-5.0

--- 1.188/sql/sp_head.cc	2005-09-26 18:21:53 +02:00
+++ 1.189/sql/sp_head.cc	2005-10-05 16:39:30 +02:00
@@ -1051,8 +1051,10 @@
      original thd->db will then have been freed */
   if (dbchanged)
   {
+    /* No access check when changing back to where we came from.
+       (It would generate an error from mysql_change_db() when olddb=="") */
     if (! thd->killed)
-      ret= mysql_change_db(thd, olddb, 0);
+      ret= mysql_change_db(thd, olddb, 1);
   }
   m_flags&= ~IS_INVOKED;
   DBUG_RETURN(ret);
Thread
bk commit into 5.0 tree (pem:1.2016) BUG#13616pem5 Oct