> The pie chart/graphical summary is also excellent, although I
> found it
> overwhelming on a lot of pages so (here it comes!) I made a couple of
> * sort the list from "most time" to "least time"
> * escape % in labels because the piechart implementation
> calls sprintf()
> on them
> * replace tab/cr/lf in labels with space to keep SQL queries from
> mangling legend
> * collapse whitespace in labels so we can see more detail
> * limit label length (before adding timings) to 40 chars
> * limit the total number of labels to 25 + an aggregate "Other"
> Based on this, I have found "Included Validation Class" to be
> the single
> largest time sink item on virtually every page (~0.055) that
> isn't a query.
I think your changes make sense (and the graphical benchmark does look
better). However, I think we should scrap that pie chart and just create
a table with information, sorted by the order in the array. That way we
can visualize the code paths and see the difference in time between one
point and the next.
I'll accept patches for 1.5.2 on this :)