MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Luis Soares Date:February 5 2010 5:51pm
Subject:bzr commit into mysql-5.1-bugteam branch (luis.soares:3369) Bug#50780
View as plain text  
#At file:///home/lsoares/Workspace/bzr/work/bugfixing/48632/mysql-5.1-bugteam-push/ based on revid:luis.soares@stripped

 3369 Luis Soares	2010-02-05
      BUG#50780: 'show binary logs' debug assertion when binary 
      logging is disabled
            
      The server would hit an assertion because of a DBUG violation.
      There was a missing DBUG_RETURN and instead a plain return
      was used.
            
      This patch replaces the return with DBUG_RETURN.

    added:
      mysql-test/r/no_binlog.result
      mysql-test/t/no_binlog.test
    modified:
      sql/sql_repl.cc
=== added file 'mysql-test/r/no_binlog.result'
--- a/mysql-test/r/no_binlog.result	1970-01-01 00:00:00 +0000
+++ b/mysql-test/r/no_binlog.result	2010-02-05 17:51:55 +0000
@@ -0,0 +1,2 @@
+SHOW BINARY LOGS;
+ERROR HY000: You are not using binary logging

=== added file 'mysql-test/t/no_binlog.test'
--- a/mysql-test/t/no_binlog.test	1970-01-01 00:00:00 +0000
+++ b/mysql-test/t/no_binlog.test	2010-02-05 17:51:55 +0000
@@ -0,0 +1,4 @@
+# BUG#50780: 'show binary logs' debug assertion when binary logging is disabled
+
+-- error ER_NO_BINARY_LOGGING
+SHOW BINARY LOGS;

=== modified file 'sql/sql_repl.cc'
--- a/sql/sql_repl.cc	2010-01-24 07:03:23 +0000
+++ b/sql/sql_repl.cc	2010-02-05 17:51:55 +0000
@@ -1606,7 +1606,7 @@ bool show_binlogs(THD* thd)
   if (!mysql_bin_log.is_open())
   {
     my_message(ER_NO_BINARY_LOGGING, ER(ER_NO_BINARY_LOGGING), MYF(0));
-    return 1;
+    DBUG_RETURN(TRUE);
   }
 
   field_list.push_back(new Item_empty_string("Log_name", 255));


Attachment: [text/bzr-bundle] bzr/luis.soares@sun.com-20100205175155-uod85vvt0k4ah6is.bundle
Thread
bzr commit into mysql-5.1-bugteam branch (luis.soares:3369) Bug#50780Luis Soares5 Feb