MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Martin Hansson Date:January 18 2010 9:59am
Subject:Re: bzr commit into mysql-5.0-bugteam branch (ramil:2841) Bug#49897
View as plain text  
Hi Ramil,

> === modified file 'sql/filesort.cc'
> --- a/sql/filesort.cc	2008-07-15 14:13:21 +0000
> +++ b/sql/filesort.cc	2010-01-16 06:05:23 +0000
> @@ -134,6 +134,7 @@ ha_rows filesort(THD *thd, TABLE *table,
>    error= 1;
>    bzero((char*) &param,sizeof(param));
>    param.sort_length= sortlength(thd, sortorder, s_length, &multi_byte_charset);
> +  DBUG_ASSERT(param.sort_length);
>   
Perhaps you could add a comment about filesort not handling zero-size 
records? Either here or in the function comment of filesort(). After all 
this is a pretty surprising limitation on a sorting algorithm!

Approved by me.

Best Regards

Martin
Thread
bzr commit into mysql-5.0-bugteam branch (ramil:2841) Bug#49897Ramil Kalimullin16 Jan
  • Re: bzr commit into mysql-5.0-bugteam branch (ramil:2841) Bug#49897Martin Hansson18 Jan