List: | Commits | « Previous MessageNext Message » | |
From: | Ramil Kalimullin | Date: | December 15 2009 9:39pm |
Subject: | Re: bzr commit into mysql-5.0-bugteam branch (ramil:2868) Bug#49465 | ||
View as plain text |
on 16.12.2009 01:14 Sergey Vojtovich wrote: > IMHO this may be more efficient here (at least easier to understand): > if (share->null_bytes > 1 && share->last_null_bit_pos) > table->record[0][share->null_bytes - 1]= > share->default_values[0][share->null_bytes - 1]; > > Ok to push even without the above change. Well, we can even do memcpy(record[0], default_values, null_bytes) but it'll hide other possible bugs. Sergei, your opinion? Thanks, Ramil.
Thread | ||
---|---|---|
• bzr commit into mysql-5.0-bugteam branch (ramil:2868) Bug#49465 | Ramil Kalimullin | 15 Dec |
• Re: bzr commit into mysql-5.0-bugteam branch (ramil:2868) Bug#49465 | Sergey Vojtovich | 15 Dec |
• Re: bzr commit into mysql-5.0-bugteam branch (ramil:2868) Bug#49465 | Ramil Kalimullin <ramil@sun.com> | 15 Dec |
• Re: bzr commit into mysql-5.0-bugteam branch (ramil:2868) Bug#49465 | Sergei Golubchik | 16 Dec |