MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Petr Chardin Date:July 20 2006 11:46am
Subject:bk commit into 5.1 tree (petr:1.2262) BUG#17599
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of cps. When cps does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-07-20 15:46:30+04:00, petr@stripped +1 -0
  Bug#17599 The server doesn't give a warning
  when --log is specified but log table is used

  sql/mysqld.cc@stripped, 2006-07-20 15:46:24+04:00, petr@stripped +13 -0
    add warnings if the filename was specified for --log
    or --log-slow_queries options, while the log tables are used

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	petr
# Host:	owlet.
# Root:	/home/cps/mysql/trees/mysql-5.1-virgin

--- 1.570/sql/mysqld.cc	2006-07-20 15:46:43 +04:00
+++ 1.571/sql/mysqld.cc	2006-07-20 15:46:43 +04:00
@@ -2770,6 +2770,19 @@
   else
     sys_init_slave.value=my_strdup("",MYF(0));
 
+  /* check log options and issues warnings if needed */
+  if (opt_log && opt_logname && !(log_output_options & LOG_FILE) &&
+      !(log_output_options & LOG_NONE))
+    sql_print_warning("Although the path was specified for "
+                      "--log option, log tables are used. "
+                      "To enable logging to file use --log-output option.");
+
+  if (opt_slow_log && opt_slow_logname && !(log_output_options & LOG_FILE)
+      && !(log_output_options & LOG_NONE))
+    sql_print_warning("Although the path was specified for "
+                      "--log-slow-queries option, log tables are used. "
+                      "To enable logging to file use --log-output option.");
+
   if (!opt_logname)
     opt_logname= make_default_log_name(buff, ".log");
   sys_var_general_log_path.value= my_strdup(opt_logname, MYF(0));
Thread
bk commit into 5.1 tree (petr:1.2262) BUG#17599Petr Chardin20 Jul