MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Jon Olav Hauglid Date:December 10 2009 1:41pm
Subject:bzr commit into mysql-5.6-next-mr branch (jon.hauglid:3028) Bug#43867
View as plain text  
#At file:///export/home/z/mysql-next-4284-bp1/ based on revid:jon.hauglid@stripped

 3028 Jon Olav Hauglid	2009-12-10
      Backport of revno: 2617.80.1
      Also re-enables the test for Bug #43867
      
      Followup to Bug#46654 False deadlock on concurrent DML/DDL with partitions, 
                            inconsistent behavior
      
      Partition_sync.test uses features only available in debug builds.
      Disabling the test for non-debug builds.

    modified:
      mysql-test/r/partition_sync.result
      mysql-test/t/partition_sync.test
=== modified file 'mysql-test/r/partition_sync.result'
--- a/mysql-test/r/partition_sync.result	2009-12-10 13:26:00 +0000
+++ b/mysql-test/r/partition_sync.result	2009-12-10 13:41:41 +0000
@@ -1,5 +1,28 @@
-# Disabled until Bug#46654 False deadlock on concurrent DML/DDL 
-# with partitions, inconsistent behavior is backported
+#
+# Bug #43867 ALTER TABLE on a partitioned table 
+#            causes unnecessary deadlocks
+#
+CREATE TABLE t1 (a int) PARTITION BY RANGE (a)
+(PARTITION p0 VALUES LESS THAN (1),
+PARTITION p1 VALUES LESS THAN (2));
+INSERT INTO t1 VALUES (0),(1);
+# Connection 2
+BEGIN;
+SELECT * FROM t1;
+a
+0
+1
+# Connection 1
+ALTER TABLE t1 DROP PARTITION p3;
+ERROR HY000: Error in list of partitions to DROP
+# Connection 2
+# This failed with deadlock and should not do so.
+SELECT * FROM t1;
+a
+0
+1
+# Connection 1
+DROP TABLE t1;
 #
 # Bug #46654 False deadlock on concurrent DML/DDL 
 #            with partitions, inconsistent behavior

=== modified file 'mysql-test/t/partition_sync.test'
--- a/mysql-test/t/partition_sync.test	2009-12-10 13:26:00 +0000
+++ b/mysql-test/t/partition_sync.test	2009-12-10 13:41:41 +0000
@@ -1,42 +1,40 @@
 --source include/have_partition.inc
+--source include/have_debug.inc
 # Save the initial number of concurrent sessions.
 --source include/count_sessions.inc
 
---echo # Disabled until Bug#46654 False deadlock on concurrent DML/DDL 
---echo # with partitions, inconsistent behavior is backported
+--echo #
+--echo # Bug #43867 ALTER TABLE on a partitioned table 
+--echo #            causes unnecessary deadlocks
+--echo #
+
+CREATE TABLE t1 (a int) PARTITION BY RANGE (a)
+(PARTITION p0 VALUES LESS THAN (1),
+ PARTITION p1 VALUES LESS THAN (2));
+
+INSERT INTO t1 VALUES (0),(1);
+
+connect(con1,localhost,root);
+
+--echo # Connection 2
+connection con1;
+BEGIN;
+SELECT * FROM t1;
 
-#--echo #
-#--echo # Bug #43867 ALTER TABLE on a partitioned table 
-#--echo #            causes unnecessary deadlocks
-#--echo #
-#
-#CREATE TABLE t1 (a int) PARTITION BY RANGE (a)
-#(PARTITION p0 VALUES LESS THAN (1),
-# PARTITION p1 VALUES LESS THAN (2));
-#
-#INSERT INTO t1 VALUES (0),(1);
-#
-#connect(con1,localhost,root);
-#
-#--echo # Connection 2
-#connection con1;
-#BEGIN;
-#SELECT * FROM t1;
-#
-#--echo # Connection 1
-#connection default;
-#--error ER_DROP_PARTITION_NON_EXISTENT
-#ALTER TABLE t1 DROP PARTITION p3;
-#
-#--echo # Connection 2
-#connection con1;
-#--echo # This failed with deadlock and should not do so.
-#SELECT * FROM t1;
-#
-#--echo # Connection 1
-#connection default;
-#disconnect con1;
-#DROP TABLE t1;
+--echo # Connection 1
+connection default;
+--error ER_DROP_PARTITION_NON_EXISTENT
+ALTER TABLE t1 DROP PARTITION p3;
+
+--echo # Connection 2
+connection con1;
+--echo # This failed with deadlock and should not do so.
+SELECT * FROM t1;
+
+--echo # Connection 1
+connection default;
+disconnect con1;
+DROP TABLE t1;
 
 
 --echo #


Attachment: [text/bzr-bundle] bzr/jon.hauglid@sun.com-20091210134141-48dn6oqenokprap8.bundle
Thread
bzr commit into mysql-5.6-next-mr branch (jon.hauglid:3028) Bug#43867Jon Olav Hauglid10 Dec