MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:kroki Date:July 17 2006 10:48am
Subject:bk commit into 5.0 tree (kroki:1.2235) BUG#21013
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of tomash. When tomash does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2006-07-17 14:48:40+04:00, kroki@stripped +3 -0
  Bug#21013: Performance Degrades when importing data that uses Trigger
             and Stored Procedure
  
  The essence of the bug was that for every re-execution of stored
  routine or prepared statement new items for character set conversions
  were created, thus increasing the number of items and the time of their
  processing, and creating memory leak.
  
  No test case is provided since current test suite can't cover such type
  of bugs.

  mysql-test/r/sp.result@stripped, 2006-07-17 14:48:38+04:00, kroki@stripped +12 -0
    Add result for bug#21013: Performance Degrades when importing data
    that uses Trigger and Stored Procedure.

  mysql-test/t/sp.test@stripped, 2006-07-17 14:48:38+04:00, kroki@stripped +27 -0
    Add test case for bug#21013: Performance Degrades when importing data
    that uses Trigger and Stored Procedure.

  sql/item.cc@stripped, 2006-07-17 14:48:38+04:00, kroki@stripped +3 -2
    Switch arena only when in statement prepare mode.  Subsequent executions
    will use cached item tree.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	kroki
# Host:	moonlight.intranet
# Root:	/home/tomash/src/mysql_ab/mysql-5.0-bug21013

--- 1.227/sql/item.cc	2006-07-17 14:48:46 +04:00
+++ 1.228/sql/item.cc	2006-07-17 14:48:46 +04:00
@@ -1418,7 +1418,8 @@
     In case we're in statement prepare, create conversion item
     in its memory: it will be reused on each execute.
   */
-  arena= thd->activate_stmt_arena_if_needed(&backup);
+  arena= thd->is_stmt_prepare() ? thd->activate_stmt_arena_if_needed(&backup)
+                                : NULL;
 
   for (i= 0, arg= args; i < nargs; i++, arg+= item_sep)
   {
@@ -1453,7 +1454,7 @@
       been created in prepare. In this case register the change for
       rollback.
     */
-    if (arena && arena->is_conventional())
+    if (arena)
       *arg= conv;
     else
       thd->change_item_tree(arg, conv);

--- 1.202/mysql-test/r/sp.result	2006-07-17 14:48:46 +04:00
+++ 1.203/mysql-test/r/sp.result	2006-07-17 14:48:46 +04:00
@@ -5057,4 +5057,16 @@
 data was: /1/
 drop table t3|
 drop procedure bug15217|
+DROP PROCEDURE IF EXISTS bug21013 |
+CREATE PROCEDURE bug21013(IN lim INT)
+BEGIN
+DECLARE i INT DEFAULT 0;
+WHILE (i < lim) DO
+SET @b = LOCATE(_latin1'b', @a, 1);
+SET i = i + 1;
+END WHILE;
+END |
+SET @a = _latin2"aaaaaaaaaa" |
+CALL bug21013(10) |
+DROP PROCEDURE bug21013 |
 drop table t1,t2;

--- 1.190/mysql-test/t/sp.test	2006-07-17 14:48:46 +04:00
+++ 1.191/mysql-test/t/sp.test	2006-07-17 14:48:46 +04:00
@@ -5962,6 +5962,33 @@
 drop table t3|
 drop procedure bug15217|
 
+
+#
+# BUG#21013: Performance Degrades when importing data that uses
+# Trigger and Stored Procedure
+#
+# This is a performance and memory leak test.  Run with large number
+# passed to bug21013() procedure.
+#
+--disable_warnings
+DROP PROCEDURE IF EXISTS bug21013 |
+--enable_warnings
+
+CREATE PROCEDURE bug21013(IN lim INT)
+BEGIN
+  DECLARE i INT DEFAULT 0;
+  WHILE (i < lim) DO
+    SET @b = LOCATE(_latin1'b', @a, 1);
+    SET i = i + 1;
+  END WHILE;
+END |
+
+SET @a = _latin2"aaaaaaaaaa" |
+CALL bug21013(10) |
+
+DROP PROCEDURE bug21013 |
+
+
 #
 # BUG#NNNN: New bug synopsis
 #
Thread
bk commit into 5.0 tree (kroki:1.2235) BUG#21013kroki17 Jul