bzr commit into mysql-5.1-bugteam branch (jimw:3218) Bug#48284

[Jim Winstead]

#At file:///Users/jimw/my/mysql-5.1--bug48284/ based on revid:joro@stripped

 3218 Jim Winstead	2009-11-23
      Fix C99 aliasing violation due to mismatched types that were papered over
      with a cast. (Bug #48284)

    modified:
      libmysql/libmysql.c
=== modified file 'libmysql/libmysql.c'
--- a/libmysql/libmysql.c	2009-11-03 18:18:44 +0000
+++ b/libmysql/libmysql.c	2009-11-23 21:54:27 +0000
@@ -2285,7 +2285,7 @@ mysql_stmt_param_metadata(MYSQL_STMT *st
 
 /* Store type of parameter in network buffer. */
 
-static void store_param_type(char **pos, MYSQL_BIND *param)
+static void store_param_type(unsigned char **pos, MYSQL_BIND *param)
 {
   uint typecode= param->buffer_type | (param->is_unsigned ? 32768 : 0);
   int2store(*pos, typecode);
@@ -2565,7 +2565,7 @@ int cli_stmt_execute(MYSQL_STMT *stmt)
 	that is sent to the server.
       */
       for (param= stmt->params;	param < param_end ; param++)
-        store_param_type((char**) &net->write_pos, param);
+        store_param_type(&net->write_pos, param);
     }
 
     for (param= stmt->params; param < param_end; param++)


Attachment: [text/bzr-bundle] bzr/[e-mail]