MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Jon Olav Hauglid Date:November 17 2009 1:53pm
Subject:bzr commit into mysql-6.0-codebase-bugfixing branch (jon.hauglid:3712)
Bug#48725
View as plain text  
#At file:///export/home/z/mysql-6.0-codebase-bugfixing-bug48725/ based on revid:holyfoot@stripped

 3712 Jon Olav Hauglid	2009-11-17
      Bug #48725 Assert !thd->is_error() in delayed_get_table()
      
      This bug is a regression introduced by the patch for Bug #45949.
      
      If the handler thread for INSERT DELAYED was killed by e.g.
      FLUSH TABLES, the error message is copied from the handler thread
      to the connection thread. But the error was not reacted on, so the
      connection thread continued as normal, leading to an eventual assert.
      
      No test case added as it would have required sync points to work
      for handler threads. The plan is to add this in the scope of 
      Bug #48725 / Bug #48541. The patch has been tested with the 
      non-deterministic test case given in the bug description.

    modified:
      sql/sql_insert.cc
=== modified file 'sql/sql_insert.cc'
--- a/sql/sql_insert.cc	2009-11-09 10:27:46 +0000
+++ b/sql/sql_insert.cc	2009-11-17 13:53:32 +0000
@@ -2103,6 +2103,7 @@ TABLE *Delayed_insert::get_local_table(T
         my_message(ER_QUERY_INTERRUPTED, ER(ER_QUERY_INTERRUPTED), MYF(0));
       else
         my_message(thd.stmt_da->sql_errno(), thd.stmt_da->message(), MYF(0));
+      goto error;
     }
   }
   share= table->s;


Attachment: [text/bzr-bundle] bzr/jon.hauglid@sun.com-20091117135332-2v8y4ig94iv49u6w.bundle
Thread
bzr commit into mysql-6.0-codebase-bugfixing branch (jon.hauglid:3712)Bug#48725Jon Olav Hauglid17 Nov
  • Re: bzr commit into mysql-6.0-codebase-bugfixing branch(jon.hauglid:3712) Bug#48725Konstantin Osipov20 Nov