MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Jon Olav Hauglid Date:October 30 2009 8:01am
Subject:bzr commit into mysql-6.0-codebase-bugfixing branch (jon.hauglid:3690)
Bug#48210
View as plain text  
#At file:///export/home/z/mysql-6.0-codebase-bugfixing-bug48315/ based on revid:marc.alff@stripped

 3690 Jon Olav Hauglid	2009-10-30
      Postfix for Bug#48210 FLUSH TABLES WITH READ LOCK deadlocks
                            against concurrent CREATE PROCEDURE
      
      Rewrote the second test to use DROP PROCEDURE instead of 
      CREATE USER as CREATE USER does not work with embedded server.

    modified:
      mysql-test/r/mdl_sync.result
      mysql-test/t/mdl_sync.test
=== modified file 'mysql-test/r/mdl_sync.result'
--- a/mysql-test/r/mdl_sync.result	2009-10-28 15:45:46 +0000
+++ b/mysql-test/r/mdl_sync.result	2009-10-30 08:01:12 +0000
@@ -273,21 +273,19 @@ FLUSH TABLES WITH READ LOCK;
 # Connection 2
 UNLOCK TABLES;
 # Connection 1
-DROP PROCEDURE p1;
 SET DEBUG_SYNC= 'RESET';
-# Test 2: CREATE USER
-# Start CREATE USER and open the grant tables
+# Test 2: DROP PROCEDURE
+# Start DROP PROCEDURE and open tables
 SET DEBUG_SYNC= 'after_open_table_mdl_shared SIGNAL table_opened WAIT_FOR grlwait';
-CREATE USER 'user_1@localhost';
+DROP PROCEDURE p1;
 # Connection 2
 SET DEBUG_SYNC= 'now WAIT_FOR table_opened';
 # Check that FLUSH must wait to get the GRL
-# and let CREATE USER continue
+# and let DROP PROCEDURE continue
 SET DEBUG_SYNC= 'wait_lock_global_read_lock SIGNAL grlwait';
 FLUSH TABLES WITH READ LOCK;
 # Connection 1
 # Connection 2
 UNLOCK TABLES;
 # Connection 1
-DROP USER 'user_1@localhost';
 SET DEBUG_SYNC= 'RESET';

=== modified file 'mysql-test/t/mdl_sync.test'
--- a/mysql-test/t/mdl_sync.test	2009-10-28 15:45:46 +0000
+++ b/mysql-test/t/mdl_sync.test	2009-10-30 08:01:12 +0000
@@ -509,21 +509,20 @@ UNLOCK TABLES;
 
 --echo # Connection 1
 connection default;
-DROP PROCEDURE p1;
 SET DEBUG_SYNC= 'RESET';
 
---echo # Test 2: CREATE USER
+--echo # Test 2: DROP PROCEDURE
 
 connection default;
---echo # Start CREATE USER and open the grant tables
+--echo # Start DROP PROCEDURE and open tables
 SET DEBUG_SYNC= 'after_open_table_mdl_shared SIGNAL table_opened WAIT_FOR grlwait';
---send CREATE USER 'user_1@localhost'
+--send DROP PROCEDURE p1
 
 --echo # Connection 2
 connection con2;
 SET DEBUG_SYNC= 'now WAIT_FOR table_opened';
 --echo # Check that FLUSH must wait to get the GRL
---echo # and let CREATE USER continue
+--echo # and let DROP PROCEDURE continue
 SET DEBUG_SYNC= 'wait_lock_global_read_lock SIGNAL grlwait';
 --send FLUSH TABLES WITH READ LOCK
 
@@ -538,7 +537,6 @@ UNLOCK TABLES;
 
 --echo # Connection 1
 connection default;
-DROP USER 'user_1@localhost';
 SET DEBUG_SYNC= 'RESET';
 
 disconnect con2;


Attachment: [text/bzr-bundle] bzr/jon.hauglid@sun.com-20091030080112-uf5pl9qyw8ha5rus.bundle
Thread
bzr commit into mysql-6.0-codebase-bugfixing branch (jon.hauglid:3690)Bug#48210Jon Olav Hauglid30 Oct