MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Bjorn Munch Date:October 26 2009 1:30pm
Subject:bzr commit into mysql-5.1-mtr branch (Bjorn.Munch:2850) Bug#48240
View as plain text  
#At file:///home/bm136801/my/summary-51/ based on revid:bjorn.munch@stripped

 2850 Bjorn Munch	2009-10-26
      Bug #48240 "Test suite timeout" and "Too many tests failed" is masked from status page
      Prepend "Completed", "Timeout" or "Too many failed" to summary line

    modified:
      mysql-test/lib/mtr_report.pm
      mysql-test/mysql-test-run.pl
=== modified file 'mysql-test/lib/mtr_report.pm'
--- a/mysql-test/lib/mtr_report.pm	2009-10-17 16:34:56 +0000
+++ b/mysql-test/lib/mtr_report.pm	2009-10-26 13:28:51 +0000
@@ -222,8 +222,8 @@ sub mtr_report_test ($) {
 }
 
 
-sub mtr_report_stats ($;$) {
-  my ($tests, $dont_error)= @_;
+sub mtr_report_stats ($$;$) {
+  my ($prefix, $tests, $dont_error)= @_;
 
   # ----------------------------------------------------------------------
   # Find out how we where doing
@@ -328,6 +328,9 @@ sub mtr_report_stats ($;$) {
     }
   }
 
+  # Print summary line prefix
+  print "$prefix: ";
+
   # Print a list of testcases that failed
   if ( $tot_failed != 0 )
   {

=== modified file 'mysql-test/mysql-test-run.pl'
--- a/mysql-test/mysql-test-run.pl	2009-10-20 10:05:28 +0000
+++ b/mysql-test/mysql-test-run.pl	2009-10-26 13:28:51 +0000
@@ -411,7 +411,7 @@ sub main {
 		 $opt_gcov_msg, $opt_gcov_err);
   }
 
-  mtr_report_stats($completed);
+  mtr_report_stats("Completed", $completed);
 
   exit(0);
 }
@@ -533,7 +533,7 @@ sub run_test_server ($$$) {
 		   $num_failed_test >= $opt_max_test_fail) {
 	      $suite_timeout_proc->kill();
 	      push(@$completed, $result);
-	      mtr_report_stats($completed, 1);
+	      mtr_report_stats("Too many failed", $completed, 1);
 	      mtr_report("Too many tests($num_failed_test) failed!",
 			 "Terminating...");
 	      return undef;
@@ -665,7 +665,7 @@ sub run_test_server ($$$) {
     # ----------------------------------------------------
     if ( ! $suite_timeout_proc->wait_one(0) )
     {
-      mtr_report_stats($completed, 1);
+      mtr_report_stats("Timeout", $completed, 1);
       mtr_report("Test suite timeout! Terminating...");
       return undef;
     }


Attachment: [text/bzr-bundle] bzr/bjorn.munch@sun.com-20091026132851-84ihmvw3o5kqs01k.bundle
Thread
bzr commit into mysql-5.1-mtr branch (Bjorn.Munch:2850) Bug#48240Bjorn Munch26 Oct