MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Mikael Ronstrom Date:October 16 2009 3:41pm
Subject:bzr commit into mysql-5.4 branch (mikael:2889)
View as plain text  
#At file:///home/mikael/mysql_clones/mysql-trunk-wl3352/

 2889 Mikael Ronstrom	2009-10-16
      Removed GLOBAL INDEX syntax, need to develop GLOBAL indexes before adding syntax for it
      modified:
        mysql-test/r/partition_not_windows.result
        mysql-test/r/partition_range.result
        mysql-test/r/partition_symlink.result
        mysql-test/t/partition_range.test
        sql/share/errmsg.txt
        sql/sql_lex.cc
        sql/sql_lex.h
        sql/sql_yacc.yy

=== modified file 'mysql-test/r/partition_not_windows.result'
--- a/mysql-test/r/partition_not_windows.result	2008-11-12 17:51:47 +0000
+++ b/mysql-test/r/partition_not_windows.result	2009-10-16 15:41:15 +0000
@@ -24,8 +24,8 @@ data directory='/not/existing'
   index directory='/not/existing'
 );
 Warnings:
-Warning	1618	<DATA DIRECTORY> option ignored
-Warning	1618	<INDEX DIRECTORY> option ignored
+Warning	1619	<DATA DIRECTORY> option ignored
+Warning	1619	<INDEX DIRECTORY> option ignored
 show create table t2;
 Table	Create Table
 t2	CREATE TABLE `t2` (

=== modified file 'mysql-test/r/partition_range.result'
--- a/mysql-test/r/partition_range.result	2009-09-15 15:07:52 +0000
+++ b/mysql-test/r/partition_range.result	2009-10-16 15:41:15 +0000
@@ -84,11 +84,6 @@ create table t1 (a int, b char(20))
 partition by range(a)
 (partition p0 values less than (column_list(1,"b")));
 ERROR HY000: Inconsistency in usage of column lists for partitioning
-create table t1 (a int, b char(20));
-create global index inx on t1 (a,b)
-partition by range (a)
-(partition p0 values less than (1));
-drop table t1;
 create table t1 (a int, b char(20))
 partition by range column_list(b)
 (partition p0 values less than (column_list("b")));

=== modified file 'mysql-test/r/partition_symlink.result'
--- a/mysql-test/r/partition_symlink.result	2008-11-12 17:51:47 +0000
+++ b/mysql-test/r/partition_symlink.result	2009-10-16 15:41:15 +0000
@@ -101,8 +101,8 @@ data directory='/not/existing'
     index directory='/not/existing'
 );
 Warnings:
-Warning	1618	<DATA DIRECTORY> option ignored
-Warning	1618	<INDEX DIRECTORY> option ignored
+Warning	1619	<DATA DIRECTORY> option ignored
+Warning	1619	<INDEX DIRECTORY> option ignored
 show create table t2;
 Table	Create Table
 t2	CREATE TABLE `t2` (

=== modified file 'mysql-test/t/partition_range.test'
--- a/mysql-test/t/partition_range.test	2009-09-15 15:07:52 +0000
+++ b/mysql-test/t/partition_range.test	2009-10-16 15:41:15 +0000
@@ -74,12 +74,6 @@ create table t1 (a int, b char(20))
 partition by range(a)
 (partition p0 values less than (column_list(1,"b")));
 
-create table t1 (a int, b char(20));
-create global index inx on t1 (a,b)
-partition by range (a)
-(partition p0 values less than (1));
-drop table t1;
-
 create table t1 (a int, b char(20))
 partition by range column_list(b)
 (partition p0 values less than (column_list("b")));

=== modified file 'sql/share/errmsg.txt'
--- a/sql/share/errmsg.txt	2009-10-06 15:01:59 +0000
+++ b/sql/share/errmsg.txt	2009-10-16 15:41:15 +0000
@@ -6182,8 +6182,6 @@ ER_TOO_LONG_FIELD_COMMENT
 
 ER_FUNC_INEXISTENT_NAME_COLLISION 42000 
   eng "FUNCTION %s does not exist. Check the 'Function Name Parsing and Resolution' section in the Reference Manual"
-ER_GLOBAL_PARTITION_INDEX_ERROR
-  eng "Partitioning of indexes only supported for global indexes"
 ER_PARTITION_COLUMN_LIST_ERROR
   eng "Inconsistency in usage of column lists for partitioning"
 ER_WRONG_TYPE_COLUMN_VALUE_ERROR

=== modified file 'sql/sql_lex.cc'
--- a/sql/sql_lex.cc	2009-10-01 13:04:42 +0000
+++ b/sql/sql_lex.cc	2009-10-16 15:41:15 +0000
@@ -323,7 +323,6 @@ void lex_start(THD *thd)
   lex->select_lex.select_number= 1;
   lex->length=0;
   lex->part_info= 0;
-  lex->global_flag= 0;
   lex->select_lex.in_sum_expr=0;
   lex->select_lex.ftfunc_list_alloc.empty();
   lex->select_lex.ftfunc_list= &lex->select_lex.ftfunc_list_alloc;

=== modified file 'sql/sql_lex.h'
--- a/sql/sql_lex.h	2009-10-01 13:04:42 +0000
+++ b/sql/sql_lex.h	2009-10-16 15:41:15 +0000
@@ -1565,9 +1565,6 @@ typedef struct st_lex : public Query_tab
   /* Partition info structure filled in by PARTITION BY parse part */
   partition_info *part_info;
 
-  /* Flag to index a global index created */
-  bool global_flag;
-
   /*
     The definer of the object being created (view, trigger, stored routine).
     I.e. the value of DEFINER clause.

=== modified file 'sql/sql_yacc.yy'
--- a/sql/sql_yacc.yy	2009-10-01 13:04:42 +0000
+++ b/sql/sql_yacc.yy	2009-10-16 15:41:15 +0000
@@ -1157,7 +1157,6 @@ bool my_yyoverflow(short **a, YYSTYPE **
         opt_natural_language_mode opt_query_expansion
         opt_ev_status opt_ev_on_completion ev_on_completion opt_ev_comment
         ev_alter_on_schedule_completion opt_ev_rename_to opt_ev_sql_stmt
-        opt_global
 
 %type <ulong_num>
         ulong_num real_ulong_num merge_insert_types
@@ -1695,12 +1694,12 @@ create:
                                   $5->table.str);
             }
           }
-        | CREATE opt_global opt_unique_or_fulltext INDEX_SYM ident key_alg ON
+        | CREATE opt_unique_or_fulltext INDEX_SYM ident key_alg ON
           table_ident
           {
             LEX *lex=Lex;
             lex->sql_command= SQLCOM_CREATE_INDEX;
-            if (!lex->current_select->add_table_to_list(lex->thd, $8,
+            if (!lex->current_select->add_table_to_list(lex->thd, $7,
                                                         NULL,
                                                         TL_OPTION_UPDATING))
               MYSQL_YYABORT;
@@ -1708,7 +1707,6 @@ create:
             lex->alter_info.flags= ALTER_ADD_INDEX;
             lex->col_list.empty();
             lex->change=NullS;
-            lex->global_flag= $2;
           }
           '(' key_list ')' key_options
           {
@@ -1719,22 +1717,13 @@ create:
               my_parse_error(ER(ER_SYNTAX_ERROR));
               MYSQL_YYABORT;
             }
-            key= new Key($3, $5.str, &lex->key_create_info, 0,
+            key= new Key($2, $4.str, &lex->key_create_info, 0,
                          lex->col_list);
             if (key == NULL)
               MYSQL_YYABORT;
             lex->alter_info.key_list.push_back(key);
             lex->col_list.empty();
           }
-          opt_partitioning
-          {
-            LEX *lex= Lex;
-            if (!lex->global_flag && lex->part_info)
-            {
-              my_error(ER_GLOBAL_PARTITION_INDEX_ERROR, MYF(0));
-              YYABORT;
-            }
-          }
         | CREATE DATABASE opt_if_not_exists ident
           {
             Lex->create_info.default_table_charset= NULL;
@@ -4454,11 +4443,6 @@ opt_part_option:
           { Lex->part_info->curr_part_elem->part_comment= $3.str; }
         ;
 
-opt_global:
-        /* empty */ { $$= FALSE;}
-        | GLOBAL_SYM { $$= TRUE; }
-        ;
-
 /*
  End of partition parser part
 */

Thread
bzr commit into mysql-5.4 branch (mikael:2889) Mikael Ronstrom16 Oct