MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Joerg Bruehe Date:September 30 2009 4:29pm
Subject:Re: bzr commit into mysql-5.4.5-next-mr branch (horst:2881) Bug#47739
View as plain text  
Horst,


maybe we do have a misunderstanding, I insert comments below:

horst hunger wrote:
> Jörg,
> to 2)
> I changed it as the "make clean" didn't delete "probes_mysql.d". The

Yes, that is a flaw in the original contents, and I have seen it.
I don't object to you changing the CLEANFILES, just ...

> ".o" was deleted by the basic clean algorithm. With my changes it works
> aas expected.
> Regards
> Horst
> Joerg Bruehe schrieb:
>> [[...]]
>>
>> 2) You removed "dtrace_files" and "dtrace_providers" from the CLEANFILES
>> macro. While they are not functionally required (unless the Makefile
>> changes), I still feel they should be contained, so that a "make clean"
>> will remove them.

... they should also be contained, so I propose you add them back.

>>
>> [[...]]
>>
>>
>> Horst Hunger wrote:
>>> #At file:///work/bzr/mysql-47146/ based on
>>> revid:horst@stripped
>>>
>>>  [[...]]
>>>  

>>> -CLEANFILES = probes_mysql.o dtrace_files dtrace_providers

>>> +CLEANFILES = probes_mysql.o $(DTRACEPROVIDER) $(DTRACEFILES)

I would like to see

     CLEANFILES = probes_mysql.o $(DTRACEPROVIDER) $(DTRACEFILES) \
                  dtrace_files dtrace_providers

Adding "$(DTRACEPROVIDER)" (= probes_mysql.d) was necessary,
for "$(DTRACEFILES)" (= .libs/ha_archive_la-ha_archive.o) I'm not sure
because it should ba covered automatically but it cannot harm,
I just miss the other two files created during the build process.

Anything I missed?


Jörg

-- 
Joerg Bruehe,  MySQL Build Team,  Joerg.Bruehe@stripped
               (+49 30) 417 01 487
Sun Microsystems GmbH,   Komturstraße 18a,   D-12099 Berlin
Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Haering     Muenchen: HRB161028

Thread
bzr commit into mysql-5.4.5-next-mr branch (horst:2881) Bug#47739Horst Hunger30 Sep
  • Re: bzr commit into mysql-5.4.5-next-mr branch (horst:2881) Bug#47739Joerg Bruehe30 Sep
    • Re: bzr commit into mysql-5.4.5-next-mr branch (horst:2881) Bug#47739horst hunger30 Sep
      • Re: bzr commit into mysql-5.4.5-next-mr branch (horst:2881) Bug#47739Joerg Bruehe30 Sep