MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Alfranio Correia Date:September 13 2009 3:41pm
Subject:Re: bzr commit into mysql-pe branch (alfranio.correia:3513) WL#5072
View as plain text  
Hi Jasonh,

Thank you for the review.
See some comments in-line.

Cheers.

He Zhenxing wrote:
> Hi Alfranio,
>
> This is a **great** work! Thank you!
>
> Here are some comments, patch approved after consideration:
>
> 1) it seems that operator '=' ignores cases normally, so SELECT 'NT' =
> 'nT' returns 1, I think you can use BINARY string like this: SELECT
> @command = BINARY 'nT' or use STRCMP function to do case sensitive
> comparison.
>   
Great catch.
> 2) There is no check if the binlog events for each statement in a
> transaction is flushed at the end of each statement or at the end of the
> transaction. I think this should be added to make sure that the SC and
> TC are flushed as expected. An easy way to do that is to show binlog
> events for each command in rpl_mixing_engines.inc.
>   
Don't you think this will clutter the output?
> 3) I think function should be used instead of procedure, because
> statements in a procedure is unrolled when binlogging, I think a NT-proc
> is equivalent to the sequence of 'N T', So I'd suggest to replace
> procedures with functions.
>   
Can you give me an example of what you have in mind?
> 4) I don't know if it's possible to add test to check if DDLs are
> written directly to binlog without going through SC or TC. I'd like to
> have such a test case if not very hard to write. Please also check the
> comment about this in the reply to WL#2687.
>   
I agree with you.
Do you have any suggestion on how I could implement this?
> Alfranio Correia wrote: 
>   
>> #At
> file:///home/acorreia/workspace.sun/repository.mysql/bzrwork/bug-40278/mysql-pe-wl2687-push/
> based on revid:alfranio.correia@stripped
>>
>>  3513 Alfranio Correia	2009-09-11
>>       WL#5072 Write a Test Case for WL 2687
>>       
>>       Checks if transactions that mixes transactional and non-transactional
> tables are
>>       correctly handled.
>>
>>     added:
>>       mysql-test/extra/rpl_tests/rpl_mixing_engines.inc
>>       mysql-test/suite/rpl/r/rpl_mixed_mixing_engines.result
>>       mysql-test/suite/rpl/r/rpl_row_mixing_engines.result
>>       mysql-test/suite/rpl/t/rpl_mixed_mixing_engines.test
>>       mysql-test/suite/rpl/t/rpl_row_mixing_engines.test
>>     modified:
>>       mysql-test/extra/rpl_tests/rpl_mixing_engines.test
>>       mysql-test/suite/rpl/r/rpl_stm_mixing_engines.result
>>       mysql-test/suite/rpl/t/rpl_stm_mixing_engines.test
>>
>>     
>
> [ snip ]
>
>
>   

Thread
bzr commit into mysql-pe branch (alfranio.correia:3513) WL#5072Alfranio Correia11 Sep
  • Re: bzr commit into mysql-pe branch (alfranio.correia:3513) WL#5072He Zhenxing13 Sep
    • Re: bzr commit into mysql-pe branch (alfranio.correia:3513) WL#5072Alfranio Correia13 Sep
      • Re: bzr commit into mysql-pe branch (alfranio.correia:3513) WL#5072He Zhenxing14 Sep
        • Re: bzr commit into mysql-pe branch (alfranio.correia:3513) WL#5072Alfranio Correia14 Sep
        • Re: bzr commit into mysql-pe branch (alfranio.correia:3513) WL#5072Alfranio Correia20 Sep
          • Re: bzr commit into mysql-pe branch (alfranio.correia:3513) WL#5072He Zhenxing21 Sep