MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Rafal Somla Date:August 18 2009 3:55pm
Subject:Re: bzr commit into mysql-6.0-backup branch (hema:2860) Bug#46758
Bug#46765
View as plain text  
Hi,

Charles Bell wrote:
> ...
> 
> +# Normally, when tests are run the test/ directory corresponding to the 
> test
> +# database is empty. In particular, it doesn't contain the db.opt file 
> storing
> +# database settings. Some tests rely on that, as they use server 
> options to
> +# determine these settings. If we backup test database
> +# (e.g., with "BACKUP DATABASE * ...") and then restore it, then it 
> will be
> +# created using "CREATE DATABASE test" statement and this will create 
> the db.opt# file. As a result, some tests run after that will fail. To 
> avoid this
> +# situation we remove the test/db.opt file as a part of clean-up.
> 
> [2] This doesn't make any sense... "Normally, when tests are run the 
> test/ directory corresponding to the test database is empty." What does 
> this mean?
> 
> [2] Poor sentence structure. "In particular, it doesn't contain the 
> db.opt file storing database settings." should be written, "The db.opt 
> file contains the database settings." But that makes no sense for the 
> comment. Do you mean, "We do not want to include the db.opt file in the 
> backup results."

The "it" in the sentence refers to the test/ directory. Thus the sentence could 
be written as

"In particular, the test/ directory doesn't contain the db.opt file storing 
database settings."

which is different from

"The db.opt file contains the database settings."

Rafal


Thread
bzr commit into mysql-6.0-backup branch (hema:2860) Bug#46758 Bug#46765Hema Sridharan17 Aug
  • Re: bzr commit into mysql-6.0-backup branch (hema:2860) Bug#46758Bug#46765Rafal Somla18 Aug
  • Re: bzr commit into mysql-6.0-backup branch (hema:2860) Bug#46758Bug#46765Charles Bell18 Aug
    • Re: bzr commit into mysql-6.0-backup branch (hema:2860) Bug#46758Bug#46765Rafal Somla18 Aug