MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Mikael Ronstrom Date:July 27 2009 3:14pm
Subject:bzr commit into mysql-5.4 branch (mikael:3477) Bug#45904
View as plain text  
#At file:///home/mikael/mysql_clones/mysql-6.0-bugteam-bug45904/

 3477 Mikael Ronstrom	2009-07-27
      Bug#45904 Used list_of_part_fields instead of list_of_subpart_fields to discover if KEY subpartitioning => caused failure when charset=utf8 even for subpartitioning by key, would also allow for subpartitioning by hash with utf8 erroneously
      modified:
        mysql-test/r/partition.result
        mysql-test/t/partition.test
        sql/sql_partition.cc

=== modified file 'mysql-test/r/partition.result'
--- a/mysql-test/r/partition.result	2009-07-02 15:51:04 +0000
+++ b/mysql-test/r/partition.result	2009-07-27 15:14:06 +0000
@@ -1,5 +1,12 @@
 SET @old_general_log= @@global.general_log;
 drop table if exists t1, t2;
+create table t1 (a int NOT NULL, b varchar(5) NOT NULL)
+default charset=utf8
+partition by list (a)
+subpartition by key (b)
+(partition p0 values in (1),
+partition p1 values in (2));
+drop table t1;
 CREATE TABLE t1 (a INT, FOREIGN KEY (a) REFERENCES t0 (a))
 ENGINE=MyISAM
 PARTITION BY HASH (a);

=== modified file 'mysql-test/t/partition.test'
--- a/mysql-test/t/partition.test	2009-07-02 15:51:04 +0000
+++ b/mysql-test/t/partition.test	2009-07-27 15:14:06 +0000
@@ -17,6 +17,16 @@ drop table if exists t1, t2;
 --enable_warnings
 
 #
+# Bug#45904: Error when CHARSET=utf8 and subpartitioning
+#
+create table t1 (a int NOT NULL, b varchar(5) NOT NULL)
+default charset=utf8
+partition by list (a)
+subpartition by key (b)
+(partition p0 values in (1),
+ partition p1 values in (2));
+drop table t1;
+#
 # Bug#36001: Partitions: spelling and using some error messages
 #
 --error ER_FOREIGN_KEY_ON_PARTITIONED

=== modified file 'sql/sql_partition.cc'
--- a/sql/sql_partition.cc	2009-07-08 12:17:27 +0000
+++ b/sql/sql_partition.cc	2009-07-27 15:14:06 +0000
@@ -1685,7 +1685,7 @@ bool fix_partition_func(THD *thd, TABLE 
   if (((part_info->part_type != HASH_PARTITION ||
       part_info->list_of_part_fields == FALSE) &&
       check_part_func_fields(part_info->part_field_array, TRUE)) ||
-      (part_info->list_of_part_fields == FALSE &&
+      (part_info->list_of_subpart_fields == FALSE &&
        part_info->is_sub_partitioned() &&
        check_part_func_fields(part_info->subpart_field_array, TRUE)))
   {

Thread
bzr commit into mysql-5.4 branch (mikael:3477) Bug#45904Mikael Ronstrom27 Jul
  • Re: bzr commit into mysql-5.4 branch (mikael:3477) Bug#45904Mattias Jonsson5 Aug