MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:July 17 2009 10:05am
Subject:Re: bzr commit into mysql-5.1-bugteam branch (davi:3013) Bug#45261
View as plain text  
Hi, Davi!

On Jul 16, Davi Arnaut wrote:
>>> === modified file 'sql/item_func.cc'
>>> --- a/sql/item_func.cc	2009-07-03 10:36:04 +0000
>>> +++ b/sql/item_func.cc	2009-07-08 13:18:39 +0000
>>> @@ -452,45 +452,8 @@ Field *Item_func::tmp_table_field(TABLE
...
>>> -      else
>>> -        /* Corrected value fits. */
>>> -        len= required_length;
>>> -    }
>>> -
>>> -    field= new Field_new_decimal(len, maybe_null, name, dec, 
>>> unsigned_flag);
>>> +    field= make_new_decimal_field();
>>>       break;
>>
>> This wasn't part of your first patch. I don't see where in the test case
>> you cover this change.
>
> Covered by tests added in patch for Bug#45262

Okay. Is the original fix for bug#45262 still necessary ?

>>> === modified file 'sql/my_decimal.h'
>>> --- a/sql/my_decimal.h	2009-07-03 10:36:04 +0000
>>> +++ b/sql/my_decimal.h	2009-07-08 13:18:39 +0000
>>> @@ -51,7 +51,6 @@ C_MODE_END
>>>   */
>>>   #define DECIMAL_MAX_PRECISION (DECIMAL_MAX_POSSIBLE_PRECISION - 8*2)
>>>   #define DECIMAL_MAX_SCALE 30
>>> -#define DECIMAL_NOT_SPECIFIED 31
>>
>> Oh, so it was unused ?
>
> No, it was used in some strange way in my_decimal_int_part. Since the 
> function was removed, it became unused.

right, that's what I meant

Regards / Mit vielen Grüßen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Engineer/Server Architect
/_/  /_/\_, /___/\___\_\___/  Sun Microsystems GmbH, HRB München 161028
       <___/                  Sonnenallee 1, 85551 Kirchheim-Heimstetten
Geschäftsführer: Thomas Schroeder, Wolfgang Engels, Wolf Frenkel
Vorsitzender des Aufsichtsrates: Martin Häring
Thread
bzr commit into mysql-5.1-bugteam branch (davi:3013) Bug#45261Davi Arnaut8 Jul
Re: bzr commit into mysql-5.1-bugteam branch (davi:3013) Bug#45261Davi Arnaut16 Jul
  • Re: bzr commit into mysql-5.1-bugteam branch (davi:3013) Bug#45261Sergei Golubchik18 Jul
Re: bzr commit into mysql-5.1-bugteam branch (davi:3013) Bug#45261Davi Arnaut17 Jul