MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:July 17 2009 11:56am
Subject:Re: bzr commit into mysql-5.1-bugteam branch (davi:3013) Bug#45261
View as plain text  
On 7/17/09 7:05 AM, Sergei Golubchik wrote:
> Hi, Davi!
>
> On Jul 16, Davi Arnaut wrote:
>>>> === modified file 'sql/item_func.cc'
>>>> --- a/sql/item_func.cc	2009-07-03 10:36:04 +0000
>>>> +++ b/sql/item_func.cc	2009-07-08 13:18:39 +0000
>>>> @@ -452,45 +452,8 @@ Field *Item_func::tmp_table_field(TABLE
> ...
>>>> -      else
>>>> -        /* Corrected value fits. */
>>>> -        len= required_length;
>>>> -    }
>>>> -
>>>> -    field= new Field_new_decimal(len, maybe_null, name, dec,
>>>> unsigned_flag);
>>>> +    field= make_new_decimal_field();
>>>>        break;
>>> This wasn't part of your first patch. I don't see where in the test case
>>> you cover this change.
>> Covered by tests added in patch for Bug#45262
>
> Okay. Is the original fix for bug#45262 still necessary ?
>

Let's say that this one will supersede the original fix.

BTW, I now realize that my explanation for the capping problem of 
Item::decimal_precision() wasn't very clear.

To be precise, the problem is that we have two components of the decimal 
value of a Item (Item::decimal_precision() and Item::decimals) and only 
one is being capped. Which gives a inaccurate "view" for performing 
calculations -- in special, calculating the integer part.

Regards,

-- Davi Arnaut
Thread
bzr commit into mysql-5.1-bugteam branch (davi:3013) Bug#45261Davi Arnaut8 Jul
Re: bzr commit into mysql-5.1-bugteam branch (davi:3013) Bug#45261Davi Arnaut16 Jul
  • Re: bzr commit into mysql-5.1-bugteam branch (davi:3013) Bug#45261Sergei Golubchik18 Jul
Re: bzr commit into mysql-5.1-bugteam branch (davi:3013) Bug#45261Davi Arnaut17 Jul