MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Sergey Vojtovich Date:March 17 2009 9:39am
Subject:Re: bzr commit into mysql-5.1-bugteam branch (satya.bn:2820) Bug#32880
View as plain text  
Hi Satya,

ok to push.

On Tue, Mar 10, 2009 at 10:04:22AM +0000, Satya B wrote:
> #At file:///home/satya/WORK/mysql-5.1-bugteam-32880/ based on
> revid:davi.arnaut@stripped
> 
>  2820 Satya B	2009-03-10
>       Fix for BUG#32880 - Repairing Archive table fails with internal error 144
>       
>       Repairing Archive table fails as the row read from the 
>       corrupted archive table is not equal the length at the time 
>       of insert.
I think that the above sentence doesn't make sense, as you have better
description below. Besides this sentence is not fully correct. Would
suggest to remove it.

>       Any statement reading corrupt archive data file
>       (CHECK/REPAIR/SELECT/UPDATE/DELETE) may cause assertion
>       failure in debug builds. This assertion has been removed
>       and an error is returned instead.
>       
>       Also fixed that CHECK/REPAIR returns vague error message
>       when it mets corruption in archive data file. This is
>       fixed by returning proper error code.
>       added:
>         mysql-test/std_data/bug32880.ARN
>         mysql-test/std_data/bug32880.ARZ
>         mysql-test/std_data/bug32880.frm
>       modified:
>         mysql-test/r/archive.result
>         mysql-test/t/archive.test
>         storage/archive/ha_archive.cc
> 
> per-file messages:
>   mysql-test/r/archive.result
>     A test case for BUG#32880
>   mysql-test/std_data/bug32880.ARN
>     corrupted archive table to test check and repair table operation
>   mysql-test/std_data/bug32880.ARZ
>     corrupted archive table to test check and repair table operation
>   mysql-test/std_data/bug32880.frm
>     corrupted archive table to test check and repair table operation
>   mysql-test/t/archive.test
>     A test case for BUG#32880
>   storage/archive/ha_archive.cc
>     Fixed unpack_row() to return the error instead of throwing assertion 
>     and also fixed repair() to throw better error when repair table
>     peration fails on corrupted archive table
s/peration/operation?

...skip...

Regards,
Sergey
-- 
Sergey Vojtovich <svoj@stripped>
MySQL AB, Software Engineer
Izhevsk, Russia, www.mysql.com
Thread
bzr commit into mysql-5.1-bugteam branch (satya.bn:2820) Bug#32880Satya B10 Mar
  • Re: bzr commit into mysql-5.1-bugteam branch (satya.bn:2820) Bug#32880Sergey Vojtovich17 Mar
  • Re: bzr commit into mysql-5.1-bugteam branch (satya.bn:2820) Bug#32880Ingo Strüwing17 Mar