List:Commits« Previous MessageNext Message »
From:He Zhenxing Date:March 2 2009 9:50am
Subject:bzr commit into mysql-6.0-rpl branch (zhenxing.he:2819) Bug#42244
View as plain text  
#At file:///media/sdb2/hezx/work/mysql/bzrwork/b42244/6.0-rpl/

 2819 He Zhenxing	2009-03-02
      BUG#42244 Segmentation fault at rpl_handler.h
      When some error caused the server to exit before calling
      delegates_init(), transaction_delegate, etc, were not initialzed,
      this would cause segmental fault when calling delegates_destroy
      because the latter does not check if the objects were NULL or not.
      Fixed the problem by only calling destruction on these objects if
      they are not NULL.

=== modified file 'sql/'
--- a/sql/	2009-01-27 02:08:48 +0000
+++ b/sql/	2009-03-02 09:50:22 +0000
@@ -115,11 +115,15 @@ int delegates_init()
 void delegates_destroy()
-  transaction_delegate->~Trans_delegate();
-  binlog_storage_delegate->~Binlog_storage_delegate();
+  if (transaction_delegate)
+    transaction_delegate->~Trans_delegate();
+  if (binlog_storage_delegate)
+    binlog_storage_delegate->~Binlog_storage_delegate();
-  binlog_transmit_delegate->~Binlog_transmit_delegate();
-  binlog_relay_io_delegate->~Binlog_relay_IO_delegate();
+  if (binlog_transmit_delegate)
+    binlog_transmit_delegate->~Binlog_transmit_delegate();
+  if (binlog_relay_io_delegate)
+    binlog_relay_io_delegate->~Binlog_relay_IO_delegate();
 #endif /* HAVE_REPLICATION */

bzr commit into mysql-6.0-rpl branch (zhenxing.he:2819) Bug#42244He Zhenxing2 Mar
  • Re: bzr commit into mysql-6.0-rpl branch (zhenxing.he:2819) Bug#42244Alfranio Correia4 Mar
    • Re: bzr commit into mysql-6.0-rpl branch (zhenxing.he:2819) Bug#42244He Zhenxing5 Mar
      • Re: bzr commit into mysql-6.0-rpl branch (zhenxing.he:2819) Bug#42244Alfranio Correia5 Mar