MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:January 28 2009 8:14pm
Subject:Re: bzr commit into mysql-5.1-bugteam branch (holyfoot:2732) Bug#37995
View as plain text  
On 12/9/08 10:11 AM, Alexey Botchkov wrote:
> #At
> file:///home/hf/work/mysql_common/37995/directory_123456789012345678901234567890/directory_123456789012345678901234567890/directory_123456789012345678901234567890/37995/
>
>   2732 Alexey Botchkov	2008-12-09
>        Bug#37995      Error message truncation in test "innodb" in embedded mode
>                as embedded-server specifies the complete file path in the error
> message,
>                the current buffer of 256 can be easily overrun, so the error message
> will
>                be cut. That leads to failing tests as the error message doesn't
> coincide.
>
>                Error buffer increased. It's not an ultimate solution, still fixes the
> issue
>                on the foreseenable perspective. And i think it's good to do anyway
> as
>                now the error message limit is 512 in the client, so cutting the
> message at
>                256 looks weird.
>
>        per-file comments:
>          include/my_sys.h
>        Bug#37995      Error message truncation in test "innodb" in embedded mode
>                error message buffer increased
>          sql/share/errmsg.txt
>        Bug#37995      Error message truncation in test "innodb" in embedded mode
>                filename in the error message can safely take up to 210 symbols.
> modified:
>    include/my_sys.h
>    sql/share/errmsg.txt
>
> === modified file 'include/my_sys.h'
> --- a/include/my_sys.h	2008-08-23 02:47:43 +0000
> +++ b/include/my_sys.h	2008-12-09 12:03:57 +0000
> @@ -39,7 +39,7 @@ extern int NEAR my_errno;		/* Last error
>   #define MYSYS_PROGRAM_DONT_USE_CURSES()  { error_handler_hook =
> my_message_no_curses; mysys_uses_curses=0;}
>   #define MY_INIT(name);		{ my_progname= name; my_init(); }
>
> -#define ERRMSGSIZE	(SC_MAXWIDTH)	/* Max length of a error message */
> +#define ERRMSGSIZE	(SC_MAXWIDTH * 2)	/* Max length of a error message */
>   #define NRERRBUFFS	(2)	/* Buffers for parameters */
>   #define MY_FILE_ERROR	((size_t) -1)
>

Please add a comment that the value of ERRMSGSIZE should probably be 
kept in sync with MYSQL_ERRMSG_SIZE. Also, shouldn't ERRMSGSIZE only be 
used by mysys? If so, please replace all uses of ERRMSGSIZE within sql/ 
with MYSQL_ERRMSG_SIZE. Another thing, what is up with errbuff? It seems 
to be mostly unused.

Regards,

-- Davi Arnaut
Thread
bzr commit into mysql-5.1-bugteam branch (holyfoot:2732) Bug#37995Alexey Botchkov9 Dec
  • Re: bzr commit into mysql-5.1-bugteam branch (holyfoot:2732) Bug#37995Davi Arnaut28 Jan