List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:January 26 2009 7:46pm
Subject:Re: bzr commit into mysql-5.0-bugteam branch (joro:2735) Bug#35396
View as plain text  
Hi Georgi,

On 1/26/09 11:00 AM, Georgi Kodinov wrote:
> #At file:///home/kgeorge/mysql/work/B35396-5.0-bugteam/ based on
> revid:davi.arnaut@stripped
>   2735 Georgi Kodinov	2009-01-26
>        Bug #35396: Abnormal query times in slow query log
>        If the system time is adjusted back during a query execution
>        (resulting in the end time being earlier than the start time)
>        the code that prints to the slow query log gets confused and
>        prints unsigned negative numbers.
>        Fixed to check for such cases and print meaningful note instead
>        of unsigned negative numbers.
>        No test case since this would involve changing the system time.

I tend to think that the real problem here is that we are not using a 
monotonic clock. Since we merely want to measure the elapsed time 
regardless of time corrections, a monotonic clock (which won't drift 
backwards) seems like a good fit. What do you think?


-- Davi Arnaut
bzr commit into mysql-5.0-bugteam branch (joro:2735) Bug#35396Georgi Kodinov26 Jan
  • Re: bzr commit into mysql-5.0-bugteam branch (joro:2735) Bug#35396Davi Arnaut26 Jan
  • Re: bzr commit into mysql-5.0-bugteam branch (joro:2735) Bug#35396Davi Arnaut28 Jan