MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Davi Arnaut Date:January 21 2009 5:40pm
Subject:Re: bzr commit into mysql-5.0-bugteam branch (chad:2713) Bug#38145
View as plain text  
Hi Chad,

OK to push with one minor comment below.

On 1/14/09 2:13 PM, Chad MILLER wrote:
> #At file:///home/cmiller/work/mysqlbzr/mysql-5.0--bug38145/ based on
> revid:chad@stripped
>
>   2713 Chad MILLER	2009-01-14
>        Bug#38145: .frm file isn't sync'd with sync_frm enabled
>
>        Views weren't sync()d the same way other structures were.
>
>        In creating the FRM for views, obey the same rules for variable
>        "sync_frm" as for everything else.
> modified:
>    sql/parse_file.cc
>
> === modified file 'sql/parse_file.cc'
> --- a/sql/parse_file.cc	2008-09-30 12:50:28 +0000
> +++ b/sql/parse_file.cc	2009-01-14 16:11:31 +0000
> @@ -263,6 +263,11 @@ sql_create_definition_file(const LEX_STR
>     if (end_io_cache(&file))
>       goto err_w_file;
>
> +  if (opt_sync_frm) {

Please obey our coding style, matching braces should be in the same 
column. Or just drop then altogether:

if (opt_sync_frm && my_sync(..))
   goto err;

Regards,

-- Davi Arnaut
Thread
bzr commit into mysql-5.0-bugteam branch (chad:2713) Bug#38145Chad MILLER14 Jan
  • Re: bzr commit into mysql-5.0-bugteam branch (chad:2713) Bug#38145Davi Arnaut21 Jan