List:Commits« Previous MessageNext Message »
From:igor Date:May 13 2006 1:24am
Subject:bk commit into 5.0 tree (igor:1.2133) BUG#19490
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of igor. When igor does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2133 06/05/12 18:24:38 igor@stripped +3 -0
  Fixed bug #19490. The bug that caused server crash manifested
  itself when executing queries referring to a view with GROUP BY
  an expression containing non-constant interval.
  It happened because Item_date_add_interval::eq neglected the
  fact that the method can be applied to an expression of the form
      date(col) + interval time_to_sec(col) second
  at the time when col could not be evaluated yet.
  An attempt to evaluate time_to_sec(col) in this method resulted
  in a crash.

  sql/item_timefunc.cc
    1.110 06/05/12 18:24:31 igor@stripped +7 -2
    Fixed bug #19490. The bug that caused server crash manifested
    itself when executing queries referring to a view with GROUP BY
    an expression containing non-constant interval.
    It happened because Item_date_add_interval::eq neglected the
    fact that the method can be applied to an expression of the form
        date(col) + interval time_to_sec(col) second
    at the time when col could not be evaluated yet.
    An attempt to evaluate time_to_sec(col) in this method resulted
    in a crash.
    The code of Item_date_add_interval::eq was corrected.

  mysql-test/t/view.test
    1.143 06/05/12 18:24:31 igor@stripped +16 -0
    Added a test case for bug #19490.

  mysql-test/r/view.result
    1.156 06/05/12 18:24:31 igor@stripped +11 -0
    Added a test case for bug #19490.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	igor
# Host:	rurik.mysql.com
# Root:	/home/igor/dev/mysql-5.0-2

--- 1.109/sql/item_timefunc.cc	2006-05-10 06:24:29 -07:00
+++ 1.110/sql/item_timefunc.cc	2006-05-12 18:24:31 -07:00
@@ -2144,8 +2144,13 @@
   Item_date_add_interval *other= (Item_date_add_interval*) item;
 
   if ((int_type != other->int_type) ||
-      (!args[0]->eq(other->args[0], binary_cmp)) ||
-      (get_interval_value(args[1], int_type, &val, &interval)))
+      (!args[0]->eq(other->args[0], binary_cmp)))
+    return FALSE;
+
+  if (!args[1]->const_item() || !other->args[1]->const_item())
+    return (args[1]->eq(other->args[1], binary_cmp)); 
+
+  if (get_interval_value(args[1], int_type, &val, &interval))
     return FALSE;
 
   val= other->value;

--- 1.155/mysql-test/r/view.result	2006-05-11 05:30:49 -07:00
+++ 1.156/mysql-test/r/view.result	2006-05-12 18:24:31 -07:00
@@ -2649,3 +2649,14 @@
 2006-01-01 03:00:00
 drop view v1, v2;
 drop table t1;
+CREATE TABLE t1 (id int NOT NULL PRIMARY KEY, d datetime);
+CREATE VIEW v1 AS
+SELECT id, date(d) + INTERVAL TIME_TO_SEC(d) SECOND AS t, COUNT(*)
+FROM t1 GROUP BY id, t;
+SHOW CREATE VIEW v1;
+View	Create View
+v1	CREATE ALGORITHM=UNDEFINED DEFINER=`root`@`localhost` SQL SECURITY DEFINER VIEW `v1` AS select `t1`.`id` AS `id`,(cast(`t1`.`d` as date) + interval time_to_sec(`t1`.`d`) second) AS `t`,count(0) AS `COUNT(*)` from `t1` group by `t1`.`id`,(cast(`t1`.`d` as date) + interval time_to_sec(`t1`.`d`) second)
+SELECT * FROM v1;
+id	t	COUNT(*)
+DROP VIEW v1;
+DROP TABLE t1;

--- 1.142/mysql-test/t/view.test	2006-04-22 00:54:21 -07:00
+++ 1.143/mysql-test/t/view.test	2006-05-12 18:24:31 -07:00
@@ -2512,3 +2512,19 @@
 select * from v2;
 drop view v1, v2;
 drop table t1;
+
+#
+# Bug #19490: usage of view specified by a query with GROUP BY
+#             an expression containing non-constant interval
+
+CREATE TABLE t1 (id int NOT NULL PRIMARY KEY, d datetime);
+
+CREATE VIEW v1 AS
+SELECT id, date(d) + INTERVAL TIME_TO_SEC(d) SECOND AS t, COUNT(*)
+  FROM t1 GROUP BY id, t;
+
+SHOW CREATE VIEW v1;
+SELECT * FROM v1;
+
+DROP VIEW v1;
+DROP TABLE t1;
Thread
bk commit into 5.0 tree (igor:1.2133) BUG#19490igor13 May