MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Gleb Shchepa Date:December 1 2008 8:14am
Subject:bzr commit into mysql-5.0-bugteam branch (gshchepa:2727) Bug#33461
View as plain text  
#At file:///work/bzr/mysql-5.0-bugteam/ based on revid:matthias.leich@stripped

 2727 Gleb Shchepa	2008-12-01
      After-push commit for bug #33461 to make valgrind happy:
      TABLE_LIST doesn't free Strings in its string lists
      (TABLE_LIST::use_index and TABLE_liST::ignore_index), so
      calling c_ptr_safe() on that Strings leads to memleaks.
      OTOH "safe" c_ptr_safe() is not necessary there and we can
      replace it with c_ptr().
modified:
  sql/sql_view.cc

=== modified file 'sql/sql_view.cc'
--- a/sql/sql_view.cc	2008-11-28 16:13:12 +0000
+++ b/sql/sql_view.cc	2008-12-01 08:14:02 +0000
@@ -985,7 +985,7 @@ bool mysql_make_view(THD *thd, File_pars
   if (index_list) 
   {
     DBUG_ASSERT(index_list->head()); // should never fail
-    my_error(ER_KEY_DOES_NOT_EXITS, MYF(0), index_list->head()->c_ptr_safe(),
+    my_error(ER_KEY_DOES_NOT_EXITS, MYF(0), index_list->head()->c_ptr(),
              table->table_name);
     DBUG_RETURN(TRUE);
   }

Thread
bzr commit into mysql-5.0-bugteam branch (gshchepa:2727) Bug#33461Gleb Shchepa1 Dec