MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Patrick Crews Date:November 11 2008 5:38pm
Subject:bzr commit into mysql-5.1 branch (patrick.crews:2705) Bug#40645
View as plain text  
#At file:///Users/pcrews/usr/local/bin/data1/work/5130/mysql-5.1-federated_innodb/

 2705 Patrick Crews	2008-11-11
      Bug#40645 Test main.federated does not always clean up after itself
      Placed call to have_innodb.inc BEFORE anything else in the test to prevent any orphan databases
      being left around to corrupt other test results.
      
      When --skip-innodb was used with mtr, we called federated.inc (and created some db's),
      then called have_innodb.inc, realized we didn't have the engine available, then left without
      cleaning up after federated.inc.  Was causing rare failures on Pushbuild.
modified:
  mysql-test/t/federated_innodb.test

=== modified file 'mysql-test/t/federated_innodb.test'
--- a/mysql-test/t/federated_innodb.test	2007-06-28 23:03:01 +0000
+++ b/mysql-test/t/federated_innodb.test	2008-11-11 17:37:45 +0000
@@ -1,5 +1,12 @@
-source include/federated.inc;
+# Keep the checks for any pre-requisites BEFORE anything else
+# Calling federated before have_innodb was causing test failures
+# in main.information_schema due to federated.inc's creation of a database
+# followed by a test-skip due to no innodb without the cleanup at the end
+# of the test.  This should apply to ALL tests - check we have everything
+# needed before doing anything else.
+
 source include/have_innodb.inc;
+source include/federated.inc;
 
 #
 # Bug#25513 Federated transaction failures

Thread
bzr commit into mysql-5.1 branch (patrick.crews:2705) Bug#40645Patrick Crews11 Nov