MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Vladislav Vaintroub Date:September 16 2008 1:23pm
Subject:bzr commit into mysql-5.1 branch (vvaintroub:2739)
View as plain text  
#At file:///G:/bzr/mysql-5.1-bugteam/

 2739 Vladislav Vaintroub	2008-09-16 [merge]
      merge fix from 5.0-bugteam
modified:
  mysys/stacktrace.c

=== modified file 'mysys/stacktrace.c'
--- a/mysys/stacktrace.c	2008-09-15 15:11:41 +0000
+++ b/mysys/stacktrace.c	2008-09-16 13:23:07 +0000
@@ -451,7 +451,12 @@ static void get_symbol_path(char *path, 
 
       if (!strstr(path, module_dir))
       {
-        strncat(path, module_dir, size);
+        size_t dir_len = strlen(module_dir);
+        if (size > dir_len)
+        {
+          strncat(path, module_dir, size-1);
+          size -= dir_len;
+        }
       }
     }
     CloseHandle(hSnap);
@@ -459,9 +464,9 @@ static void get_symbol_path(char *path, 
 
   /* Add _NT_SYMBOL_PATH, if present. */
   envvar= getenv("_NT_SYMBOL_PATH");
-  if(envvar)
+  if(envvar && size)
   {
-    strncat(path, envvar, size);
+    strncat(path, envvar, size-1);
   }
 }
 
@@ -483,7 +488,7 @@ void my_print_stacktrace(uchar* unused1,
   int     i;
   CONTEXT context;
   STACKFRAME64 frame={0};
-  static char symbol_path[MAX_SYMBOL_PATH+1];
+  static char symbol_path[MAX_SYMBOL_PATH];
 
   if(!exception_ptrs || !init_dbghelp_functions())
     return;
@@ -492,7 +497,7 @@ void my_print_stacktrace(uchar* unused1,
   context = *(exception_ptrs->ContextRecord);
   /*Initialize symbols.*/
   pSymSetOptions(SYMOPT_LOAD_LINES|SYMOPT_NO_PROMPTS|SYMOPT_DEFERRED_LOADS|SYMOPT_DEBUG);
-  get_symbol_path(symbol_path, MAX_SYMBOL_PATH);
+  get_symbol_path(symbol_path, sizeof(symbol_path));
   pSymInitialize(hProcess, symbol_path, TRUE);
 
   /*Prepare stackframe for the first StackWalk64 call*/

Thread
bzr commit into mysql-5.1 branch (vvaintroub:2739) Vladislav Vaintroub16 Sep