MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Andrei Elkin Date:September 16 2008 10:08am
Subject:bzr commit into mysql-5.1 branch (aelkin:2687) Bug#15580, Bug#28786
View as plain text  
#At file:///home/andrei/MySQL/BZR/FIXES/5.1-rpl-bug28786-binlog_killed.test/

 2687 Andrei Elkin	2008-09-16
      Bug #28786 binlog_killed.test fails: 'reset master' does not reset binlogging
      The test failed originally -- did not reset binlogging - for the reason
      identified by bug#15580.
      However it can not run on the embedded platfrom for yet another cause -
      the embedded can not KILL query.
      Fixed with adding comments to the test particularly addressing `reset master'
      to the mentioned bug.

per-file messages:
    adding commets explaining why the test has to have include/ guard.
=== modified file 'mysql-test/suite/binlog/t/binlog_killed.test'
--- a/mysql-test/suite/binlog/t/binlog_killed.test	2008-02-28 11:21:44 +0000
+++ b/mysql-test/suite/binlog/t/binlog_killed.test	2008-09-16 10:08:29 +0000
@@ -1,5 +1,10 @@
 -- source include/
 -- source include/
+# You cannot use `KILL' with the Embedded MySQL Server library,
+# because the embedded server merely runs inside the threads of the host
+# application. -- the docs
 -- source include/
@@ -22,6 +27,12 @@ select get_lock("a", 20);
 connection con2;
 let $ID= `select connection_id()`;
+# reset master does not reset binlogging on the embedded server.
+# the test is not run on the embedded for reason of using KILL query.
+# `reset master' problem is to be addressed by bug#15580 fixes.
 reset master;
 send insert into t2 values (null, null), (null, get_lock("a", 10));

bzr commit into mysql-5.1 branch (aelkin:2687) Bug#15580, Bug#28786Andrei Elkin16 Sep