MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Chuck Bell Date:August 13 2008 5:02pm
Subject:RE: bzr commit into mysql-6.0-backup branch (cbell:2638) Bug#33364, Bug#35230, WL#4296
View as plain text  
Oystein,

Just to let you know you aren't missing anything. There is indeed a bug in
this code which I have fixed. Golly. 

> >>  > +void Logger::report_engine(const char *engine_name)  > +{
> >>  > +  String str;    // engines string
> >>  > +  DBUG_ASSERT(m_state == READY || m_state == RUNNING); 
>  > +  > +  
> >> str.length(0);  > +  if (m_op_hist->engine_name &&
> >>  > +      (strlen(m_op_hist->engine_name) > 0) &&
> >>  > +      (strlen(engine_name) > 0))
> >>  > +    str.append(", ");
> >>  > +  if (strlen(engine_name) > 0)
> >>  > +    str.append(engine_name);
> >>  > +  if (str.length() > 0)
> >>  > +  {
> >>  > +    if (m_op_hist->engine_name)
> >>  > +      delete m_op_hist->engine_name;
> >>  > +    m_op_hist->engine_name = new char[str.length()+1];
> >>  > +    strcpy(m_op_hist->engine_name, str.ptr());
> >>  > +  }
> >>  > +}

New patch later this week...fixing lots and lots of things.

Chuck

Thread
bzr commit into mysql-6.0-backup branch (cbell:2638) Bug#33364, Bug#35230,WL#4296Chuck Bell25 Jun
  • Re: bzr commit into mysql-6.0-backup branch (cbell:2638) Bug#33364,Bug#35230, WL#4296Rafal Somla30 Jun
    • RE: bzr commit into mysql-6.0-backup branch (cbell:2638) Bug#33364, Bug#35230, WL#4296Chuck Bell2 Jul
      • Re: bzr commit into mysql-6.0-backup branch (cbell:2638) Bug#33364,Bug#35230, WL#4296Rafal Somla2 Jul
        • Re: bzr commit into mysql-6.0-backup branch (cbell:2638) Bug#33364,Bug#35230, WL#4296Rafal Somla2 Jul
          • RE: bzr commit into mysql-6.0-backup branch (cbell:2638) Bug#33364, Bug#35230, WL#4296Chuck Bell2 Jul
        • RE: bzr commit into mysql-6.0-backup branch (cbell:2638) Bug#33364, Bug#35230, WL#4296Chuck Bell2 Jul
  • Re: bzr commit into mysql-6.0-backup branch (cbell:2638) Bug#33364,Bug#35230, WL#4296Øystein Grøvlen5 Aug
    • RE: bzr commit into mysql-6.0-backup branch (cbell:2638) Bug#33364, Bug#35230, WL#4296Chuck Bell5 Aug
      • Re: bzr commit into mysql-6.0-backup branch (cbell:2638) Bug#33364,Bug#35230, WL#4296Øystein Grøvlen7 Aug
        • RE: bzr commit into mysql-6.0-backup branch (cbell:2638) Bug#33364, Bug#35230, WL#4296Chuck Bell13 Aug