List:Commits« Previous MessageNext Message »
From:Alexander Barkov Date:August 1 2008 6:57am
Subject:Re: commit into mysql-5.1 branch (bar:2680) Bug#35808
View as plain text  
Hi Joerg,

Joerg Bruehe wrote:
> Hi Bar !
> 
> 
> Alexander Barkov wrote:
>> #At file:///home/bar/mysql-bzr/mysql-5.1.b35808/
>>
>>  2680 Alexander Barkov    2008-07-29
>>       Bug#35808 utf8 hungarian collation not part of the utf8 charset?
>>       config/ac-macros/character_sets.m4 didn't mention hungarian 
>> collations
>>       in the UTF8 and UCS2 lists.
>> modified:
>>   config/ac-macros/character_sets.m4
> 
> Have you run the full tests on this, including the "extra" suites 
> (funcs_1, ...) ?
> I expect this change will cause output which differs from the current 
> test result files for "charset_collation_*", so these tests will fail -
> and I do NOT like this as a surprise in release builds !
> 
> Please run "make test-bt" to verify they still pass.

Thanks for your concern!

I had not run full tests before pushing.
My patch does not affect test output in any ways.
It just allows to use "configure --with-collation=utf8_hungarian_ci",
nothing else (this collation was forgotten for some reasons).
Before this patch configure complained that utf8_hungarian_ci is
an unknown collation.

So the fix changes only how "configure" work.
It doesn't affect neither "mysqld" nor "mysql"
nor any other tools compiled during build process.
In particular, it does not change INFORMATION_SCHEMA content,
which is tested in "charset_collation_*" tests.

Just in case, I have just run "funcs_1" test suite and it passed.


> 
>>
>> === modified file 'config/ac-macros/character_sets.m4'
>> --- a/config/ac-macros/character_sets.m4    2008-02-26 17:36:06 +0000
>> +++ b/config/ac-macros/character_sets.m4    2008-07-29 03:25:46 +0000
>> @@ -343,8 +343,8 @@
>>        default_charset_default_collation="ucs2_general_ci"
>>        define(UCSC1, ucs2_general_ci ucs2_bin)
>>        define(UCSC2, ucs2_czech_ci ucs2_danish_ci)
>> -      define(UCSC3, ucs2_esperanto_ci ucs2_estonian_ci 
>> ucs2_icelandic_ci)
>> -      define(UCSC4, ucs2_latvian_ci ucs2_lithuanian_ci)
>> +      define(UCSC3, ucs2_esperanto_ci ucs2_estonian_ci 
>> ucs2_hungarian_ci)
>> +      define(UCSC4, ucs2_icelandic_ci ucs2_latvian_ci 
>> ucs2_lithuanian_ci)
>>        define(UCSC5, ucs2_persian_ci ucs2_polish_ci ucs2_romanian_ci)
>>        define(UCSC6, ucs2_slovak_ci ucs2_slovenian_ci)
>>        define(UCSC7, ucs2_spanish2_ci ucs2_spanish_ci)
>> @@ -367,8 +367,8 @@
>>        else
>>          define(UTFC1, utf8_general_ci utf8_bin)
>>          define(UTFC2, utf8_czech_ci utf8_danish_ci)
>> -        define(UTFC3, utf8_esperanto_ci utf8_estonian_ci 
>> utf8_icelandic_ci)
>> -        define(UTFC4, utf8_latvian_ci utf8_lithuanian_ci)
>> +        define(UTFC3, utf8_esperanto_ci utf8_estonian_ci 
>> utf8_hungarian_ci)
>> +        define(UTFC4, utf8_icelandic_ci utf8_latvian_ci 
>> utf8_lithuanian_ci)
>>          define(UTFC5, utf8_persian_ci utf8_polish_ci utf8_romanian_ci)
>>          define(UTFC6, utf8_slovak_ci utf8_slovenian_ci)
>>          define(UTFC7, utf8_spanish2_ci utf8_spanish_ci)
> 
> 
> Regards,
> Jörg
> 

Thread
commit into mysql-5.1 branch (bar:2680) Bug#35808Alexander Barkov29 Jul
  • Re: commit into mysql-5.1 branch (bar:2680) Bug#35808Joerg Bruehe31 Jul
    • Re: commit into mysql-5.1 branch (bar:2680) Bug#35808Alexander Barkov1 Aug