List:Commits« Previous MessageNext Message »
From:Chuck Bell Date:June 30 2008 7:21pm
Subject:RE: WL#4222 Test patch review
View as plain text  
Hema,

I'm sorry but there is something wrong with the tests. There are random
failures (the worst kind). I suggest two things; 1) run the tests in a loop
until they fail so you can see what is wrong, and 2) be sure that you
include clean up sections that properly delete all objects before/after each
test. I have a deep suspicion that repeated nested tests like these are very
sensitive to cleanup. 

backup.backup_functions 'innodb' [ pass ]           2394
backup.backup_procedures 'innodb' [ pass ]            707
backup.backup_triggers 'innodb' [ pass ]           3073
backup.backup_functions 'falcon' [ pass ]           1456
backup.backup_procedures 'falcon' [ pass ]            836
backup.backup_triggers 'falcon' [ pass ]           2485
backup.backup_functions 'myisam' [ pass ]           1930
backup.backup_procedures 'myisam' [ pass ]            754
backup.backup_triggers 'myisam' [ fail ]

mysqltest: At line 208: query 'RESTORE FROM 'bup_ts.bak'' failed: 7: Error
on re
name of '.\bup_ts\cap.TRG~' to '.\bup_ts\cap.TRG' (Errcode: 17)

The result from queries just before the failure was:
< snip >
Create Table    CREATE TABLE `city` (
  `id` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `name` varchar(20) DEFAULT NULL,
  `ccode` char(10) DEFAULT NULL,
  `population` bigint(20) DEFAULT NULL,
  PRIMARY KEY (`id`)
) ENGINE=ENGINE AUTO_INCREMENT=9 DEFAULT CHARSET=latin1
SHOW CREATE TABLE t2;;
Table   t2
Create Table    CREATE TABLE `t2` (
  `a` char(4) DEFAULT NULL
) ENGINE=ENGINE DEFAULT CHARSET=latin1
backup data
BACKUP DATABASE bup_ts TO 'bup_ts.bak';
backup_id
#
dropping  database.
DROP DATABASE bup_ts;
perform restore
RESTORE FROM 'bup_ts.bak';

Also, BUG#35249 is 'patch queued' so you must remove the code in the
triggers test that disables the memory run.

> --replace_result $ENGINE ENGINE
> eval SELECT '$ENGINE'='memory';
> if(`SELECT '$ENGINE'='memory'`)
> {
>  skip Temporarily Disabled Bug#35249 ;
> }

One more thing... I see that it is now impossible to run these tests on a
system that has only MyISAM built. The tests are designed so that one has to
have innodb, falcon, myisam, and memory storage engines built/installed in
order to run the tests. I wonder if that is such a good idea?

I think maybe you need to remove the have_falcon, have_innodb, etc. and
handle it like you do above with the engines thing. Only please make a more
informative message. 'Temporarily disabled' sounds like it is disabled as in
disabled.def file but it isn't. In this case, you should print a message
like 'Test skipped. No InnoDB support.'

Chuck

Thread
WL#4222 Test patch reviewChuck Bell12 Jun
  • RE: WL#4222 Test patch reviewHema Sridharan13 Jun
    • RE: WL#4222 Test patch reviewChuck Bell13 Jun
      • RE: WL#4222 Test patch reviewHema Sridharan24 Jun
        • RE: WL#4222 Test patch reviewChuck Bell30 Jun
          • RE: WL#4222 Test patch reviewHema Sridharan1 Jul
            • RE: WL#4222 Test patch reviewChuck Bell1 Jul
              • RE: WL#4222 Test patch reviewHema Sridharan2 Jul
                • RE: WL#4222 Test patch reviewChuck Bell2 Jul
                  • RE: WL#4222 Test patch reviewHema Sridharan3 Jul
                    • RE: WL#4222 Test patch reviewChuck Bell21 Jul
                      • RE: WL#4222 Test patch reviewHema Sridharan23 Jul
                        • RE: WL#4222 Test patch reviewChuck Bell23 Jul
                          • Re: WL#4222 Test patch reviewJoerg Bruehe31 Jul
                            • RE: WL#4222 Test patch reviewHema Sridharan1 Aug
                              • Re: WL#4222 Test patch reviewJoerg Bruehe1 Aug
                      • RE: WL#4222 Test patch reviewHema Sridharan7 Aug
                        • RE: WL#4222 Test patch reviewChuck Bell11 Aug
                          • RE: WL#4222 Test patch reviewHema Sridharan11 Aug
RE: WL#4222 Test patch reviewChuck Bell30 Jun
  • RE: WL#4222 Test patch reviewHema Sridharan30 Jun