MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Sergey Vojtovich Date:April 12 2006 11:32am
Subject:bk commit into 4.1 tree (svoj:1.2502) BUG#17917
View as plain text  
Below is the list of changes that have just been committed into a local
4.1 repository of svoj. When svoj does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2502 06/04/12 16:32:39 svoj@april.(none) +1 -0
  BUG#17917 - SELECT from compressed MyISAM table crashes MySQL server
  
  Retrieving data from compressed MyISAM table which is bigger than 4G on 32-bit box
  with mmap() support results in server crash.
  
  mmap() accepts length of bytes to be mapped in second param, which is 32-bit
  size_t. But we pass data_file_length, which is 64-bit my_off_t. As a result only
  first data_file_length % 4G were mapped.
  
  This fix adds additional condition for mmap() usage, that is use mmap() for
  compressed table which size is no more than 4G on 32-bit platform.

  myisam/mi_packrec.c
    1.28 06/04/12 16:32:36 svoj@april.(none) +6 -0
    Use mmap() for compressed table which size is no more than 4G on 32-bit platform.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	svoj
# Host:	april.(none)
# Root:	/home/svoj/devel/mysql/BUG17917/mysql-4.1

--- 1.27/myisam/mi_packrec.c	2005-09-05 16:31:35 +05:00
+++ 1.28/myisam/mi_packrec.c	2006-04-12 16:32:36 +05:00
@@ -1160,6 +1160,12 @@
 
   if (!info->s->file_map)
   {
+    if (share->state.state.data_file_length > 
+        (my_off_t)(~((size_t)0)) - MEMMAP_EXTRA_MARGIN)
+    {
+      DBUG_PRINT("warning", ("File is too large for mmap"));
+      DBUG_RETURN(0);
+    }
     if (my_seek(info->dfile,0L,MY_SEEK_END,MYF(0)) <
 	share->state.state.data_file_length+MEMMAP_EXTRA_MARGIN)
     {
Thread
bk commit into 4.1 tree (svoj:1.2502) BUG#17917Sergey Vojtovich12 Apr