List:Commits« Previous MessageNext Message »
From:jonas Date:April 6 2006 2:18pm
Subject:bk commit into 4.1 tree (jonas:1.2492) BUG#18612
View as plain text  
Below is the list of changes that have just been committed into a local
4.1 repository of jonas. When jonas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2492 06/04/06 16:18:42 jonas@stripped +2 -0
  ndb - bug#18612 - post review fixes
    1) make sure that check_multi_node_shutdown does not proceed (in stop case)
    2) Fix printout

  ndb/src/kernel/blocks/qmgr/QmgrMain.cpp
    1.21 06/04/06 16:18:41 jonas@stripped +15 -5
    make sure that check_multi_node_shutdown does not proceed (in stop case)

  ndb/src/kernel/blocks/qmgr/Qmgr.hpp
    1.8 06/04/06 16:18:40 jonas@stripped +1 -1
    make sure that check_multi_node_shutdown does not proceed (in stop case)

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jonas
# Host:	perch.ndb.mysql.com
# Root:	/home/jonas/src/41-work

--- 1.7/ndb/src/kernel/blocks/qmgr/Qmgr.hpp	2006-04-03 11:26:27 +02:00
+++ 1.8/ndb/src/kernel/blocks/qmgr/Qmgr.hpp	2006-04-06 16:18:40 +02:00
@@ -409,7 +409,7 @@
   Uint16 ccommitFailedNodes[MAX_NDB_NODES];
   
   StopReq c_stopReq;
-  void check_multi_node_shutdown(Signal* signal);
+  bool check_multi_node_shutdown(Signal* signal);
 };
 
 #endif

--- 1.20/ndb/src/kernel/blocks/qmgr/QmgrMain.cpp	2006-04-03 11:26:27 +02:00
+++ 1.21/ndb/src/kernel/blocks/qmgr/QmgrMain.cpp	2006-04-06 16:18:41 +02:00
@@ -2296,7 +2296,11 @@
   ptrCheckGuard(failedNodePtr, MAX_NODES, nodeRec);
   FailRep* rep = (FailRep*)signal->getDataPtr();
 
-  check_multi_node_shutdown(signal);
+  if (check_multi_node_shutdown(signal))
+  {
+    jam();
+    return;
+  }
   
   if (failedNodePtr.i == getOwnNodeId()) {
     jam();
@@ -2360,8 +2364,8 @@
 			 "We(%u) have been declared dead by %u reason: %s(%u)",
 			 getOwnNodeId(),
 			 refToNode(signal->getSendersBlockRef()),
-			 aFailCause,
-			 msg ? msg : "<Unknown>");
+			 msg ? msg : "<Unknown>",
+			 aFailCause);
     
     progError(__LINE__, code, buf);
     return;
@@ -2421,7 +2425,11 @@
   NodeRecPtr myNodePtr;
   jamEntry();
   
-  check_multi_node_shutdown(signal);
+  if (check_multi_node_shutdown(signal))
+  {
+    jam();
+    return;
+  }
   
   PrepFailReqRef * const prepFail = (PrepFailReqRef *)&signal->theData[0];
 
@@ -4255,7 +4263,7 @@
   }
 }
 
-void
+bool
 Qmgr::check_multi_node_shutdown(Signal* signal)
 {
   if (c_stopReq.senderRef && 
@@ -4271,5 +4279,7 @@
     } else {
       EXECUTE_DIRECT(CMVMI, GSN_STOP_ORD, signal, 1);
     }
+    return true;
   }
+  return false;
 }
Thread
bk commit into 4.1 tree (jonas:1.2492) BUG#18612jonas6 Apr