MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Stewart Smith Date:April 6 2006 11:59am
Subject:bk commit into 4.1 tree (stewart:1.2499) BUG#18833
View as plain text  
Below is the list of changes that have just been committed into a local
4.1 repository of stewart. When stewart does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2499 06/04/06 21:59:20 stewart@stripped +1 -0
  BUG#18833 valgrind: Mismatched free()/delete/delete[] in SimBlockList

  ndb/src/kernel/SimBlockList.cpp
    1.8 06/04/06 21:59:15 stewart@stripped +4 -0
    NEW_BLOCK allocates the elements with new, we should free them with delete
    but only if we're not building with VM_TRACE

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	stewart
# Host:	willster.(none)
# Root:	/home/stewart/Documents/MySQL/4.1/bug18833

--- 1.7/ndb/src/kernel/SimBlockList.cpp	2005-08-18 22:02:19 +10:00
+++ 1.8/ndb/src/kernel/SimBlockList.cpp	2006-04-06 21:59:15 +10:00
@@ -111,8 +111,12 @@
   if(theList != 0){
     for(int i = 0; i<noOfBlocks; i++){
       if(theList[i] != 0){
+#ifdef VM_TRACE
 	theList[i]->~SimulatedBlock();
 	free(theList[i]);
+#else
+        delete(theList[i]);
+#endif
 	theList[i] = 0;
       }
     }
Thread
bk commit into 4.1 tree (stewart:1.2499) BUG#18833Stewart Smith6 Apr