MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:igor Date:April 4 2006 4:02am
Subject:bk commit into 5.0 tree (igor:1.2127) BUG#16504
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of igor. When igor does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2127 06/04/03 21:02:40 igor@stripped +3 -0
  Post review changes for the fix of bug #16504.

  sql/sql_select.cc
    1.404 06/04/03 21:02:34 igor@stripped +13 -14
    Post review changes for the fix of bug #16504.

  sql/item_cmpfunc.h
    1.122 06/04/03 21:02:34 igor@stripped +1 -1
    Post review changes for the fix of bug #16504.

  sql/item_cmpfunc.cc
    1.197 06/04/03 21:02:34 igor@stripped +2 -2
    Post review changes for the fix of bug #16504.

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	igor
# Host:	rurik.mysql.com
# Root:	/home/igor/dev/mysql-5.0-0

--- 1.196/sql/item_cmpfunc.cc	2006-03-31 21:26:11 -08:00
+++ 1.197/sql/item_cmpfunc.cc	2006-04-03 21:02:34 -07:00
@@ -3740,7 +3740,7 @@
   Check appearance of new constant items in the multiple equality object
 
   SYNOPSIS
-    check()
+    update_const()
   
   DESCRIPTION
     The function checks appearance of new constant items among
@@ -3753,7 +3753,7 @@
     none    
 */
 
-void Item_equal::check_const()
+void Item_equal::update_const()
 {
   List_iterator<Item_field> it(fields);
   Item *item;

--- 1.121/sql/item_cmpfunc.h	2006-03-31 21:26:11 -08:00
+++ 1.122/sql/item_cmpfunc.h	2006-04-03 21:02:34 -07:00
@@ -1196,7 +1196,7 @@
   bool contains(Field *field);
   Item_field* get_first() { return fields.head(); }
   void merge(Item_equal *item);
-  void check_const();
+  void update_const();
   enum Functype functype() const { return MULT_EQUAL_FUNC; }
   longlong val_int(); 
   const char *func_name() const { return "multiple equal"; }

--- 1.403/sql/sql_select.cc	2006-03-31 21:26:11 -08:00
+++ 1.404/sql/sql_select.cc	2006-04-03 21:02:34 -07:00
@@ -136,7 +136,7 @@
 end_write_group(JOIN *join, JOIN_TAB *join_tab, bool end_of_records);
 
 static int test_if_group_changed(List<Cached_item> &list);
-static int join_read_const_table(JOIN *join, JOIN_TAB *tab, POSITION *pos);
+static int join_read_const_table(JOIN_TAB *tab, POSITION *pos);
 static int join_read_system(JOIN_TAB *tab);
 static int join_read_const(JOIN_TAB *tab);
 static int join_read_key(JOIN_TAB *tab);
@@ -2111,7 +2111,7 @@
     s= p_pos->table;
     s->type=JT_SYSTEM;
     join->const_table_map|=s->table->map;
-    if ((tmp=join_read_const_table(join, s, p_pos)))
+    if ((tmp=join_read_const_table(s, p_pos)))
     {
       if (tmp > 0)
 	DBUG_RETURN(1);			// Fatal error
@@ -2148,8 +2148,7 @@
 	  s->type=JT_SYSTEM;
 	  join->const_table_map|=table->map;
 	  set_position(join,const_count++,s,(KEYUSE*) 0);
-	  if ((tmp= join_read_const_table(join, s,
-                                          join->positions+const_count-1)))
+	  if ((tmp= join_read_const_table(s, join->positions+const_count-1)))
 	  {
 	    if (tmp > 0)
 	      DBUG_RETURN(1);			// Fatal error
@@ -2201,8 +2200,8 @@
 	      if (create_ref_for_key(join, s, start_keyuse,
 				     found_const_table_map))
 		DBUG_RETURN(1);
-	      if ((tmp=join_read_const_table(join, s,
-					     join->positions+const_count-1)))
+	      if ((tmp=join_read_const_table(s,
+                                             join->positions+const_count-1)))
 	      {
 		if (tmp > 0)
 		  DBUG_RETURN(1);			// Fatal error
@@ -7183,7 +7182,7 @@
   of a condition after reading a constant table
  
   SYNOPSIS
-    check_const_equal_item()
+    update_const_equal_items()
     cond       condition whose multiple equalities are to be checked
     table      constant table that has been read 
 
@@ -7194,8 +7193,7 @@
     the multiple equality appropriately.
 */
 
-static void check_const_equal_items(COND *cond,
-                                    JOIN_TAB *tab)
+static void update_const_equal_items(COND *cond, JOIN_TAB *tab)
 {
   if (!(cond->used_tables() & tab->table->map))
     return;
@@ -7206,13 +7204,13 @@
     List_iterator_fast<Item> li(*cond_list);
     Item *item;
     while ((item= li++))
-      check_const_equal_items(item, tab);
+      update_const_equal_items(item, tab);
   }
   else if (cond->type() == Item::FUNC_ITEM && 
            ((Item_cond*) cond)->functype() == Item_func::MULT_EQUAL_FUNC)
   {
     Item_equal *item_equal= (Item_equal *) cond;
-    item_equal->check_const();
+    item_equal->update_const();
   }
 }
 
@@ -10139,7 +10137,7 @@
 
 
 static int
-join_read_const_table(JOIN *join, JOIN_TAB *tab, POSITION *pos)
+join_read_const_table(JOIN_TAB *tab, POSITION *pos)
 {
   int error;
   DBUG_ENTER("join_read_const_table");
@@ -10193,8 +10191,9 @@
     table->maybe_null=0;
 
   /* Check appearance of new constant items in Item_equal objects */
+  JOIN *join= tab->join;
   if (join->conds)
-    check_const_equal_items(join->conds, tab);
+    update_const_equal_items(join->conds, tab);
   TABLE_LIST *tbl;
   for (tbl= join->select_lex->leaf_tables; tbl; tbl= tbl->next_leaf)
   {
@@ -10204,7 +10203,7 @@
     {
       embedded= embedding;
       if (embedded->on_expr)
-         check_const_equal_items(embedded->on_expr, tab);
+         update_const_equal_items(embedded->on_expr, tab);
       embedding= embedded->embedding;
     }
     while (embedding &&
Thread
bk commit into 5.0 tree (igor:1.2127) BUG#16504igor4 Apr