MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:cpowers Date:March 4 2008 3:17am
Subject:bk commit into 6.0 tree (cpowers:1.2587) BUG#34567
View as plain text  
Below is the list of changes that have just been committed into a local
6.0 repository of cpowers.  When cpowers does a push these changes
will be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2008-03-03 21:17:42-06:00, cpowers@stripped +1 -0
  Bug#34567, "Falcon deadlock between ALTERS of temporary tables"
  
  Added debugging code to Statement::start.

  storage/falcon/Statement.cpp@stripped, 2008-03-03 21:17:39-06:00, cpowers@stripped +12 -0
    Added debugging code to Statement::start(). Test that system transactions hold
    Database::syncSysDDL, and that update verbs (insert, update, delete, replace)
    hold it exclusively.
    
    One exception to this is updateCardinalities.

diff -Nrup a/storage/falcon/Statement.cpp b/storage/falcon/Statement.cpp
--- a/storage/falcon/Statement.cpp	2008-03-03 12:40:15 -06:00
+++ b/storage/falcon/Statement.cpp	2008-03-03 21:17:39 -06:00
@@ -469,6 +469,18 @@ void Statement::start(NNode * node)
 	transaction->addRef();
 	int savePoint = transaction->createSavepoint();
 
+	// System transactions should hold syncSysDDL, and update verbs should hold it exclusively
+	
+	/***
+	if (transaction->systemTransaction)
+		{
+		if (node->isUpdateVerb())
+			ASSERT(database->syncSysDDL.ourExclusiveLock());
+		else
+			ASSERT(database->syncSysDDL.isLocked());
+		}
+	***/
+	
 	try
 		{
 		active = true;
Thread
bk commit into 6.0 tree (cpowers:1.2587) BUG#34567cpowers4 Mar