MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:antony Date:February 19 2008 9:47pm
Subject:bk commit into 5.1 tree (acurtis:1.2524)
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of acurtis.  When acurtis does a push these changes
will be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2008-02-19 13:46:54-08:00, acurtis@stripped +2 -0
  backport valgrind cleanups from 6.0-engines

  mysql-test/valgrind.supp@stripped, 2008-02-19 13:46:50-08:00, acurtis@stripped +13 -0
    silence valgrind warning of memory leak in dlopen

  strings/strmake.c@stripped, 2008-02-19 13:46:50-08:00, acurtis@stripped +3 -3
    silence valgrind warning cause by strlen examining unset bytes.

diff -Nrup a/mysql-test/valgrind.supp b/mysql-test/valgrind.supp
--- a/mysql-test/valgrind.supp	2007-05-21 05:48:28 -07:00
+++ b/mysql-test/valgrind.supp	2008-02-19 13:46:50 -08:00
@@ -495,3 +495,16 @@
    fun:_db_enter_
    fun:kill_server
 }
+
+#
+# Warning caused by small memory leak in threaded dlopen
+#
+
+{
+   dlopen threaded memory leak
+   Memcheck:Leak
+   fun:calloc
+   obj:*/libdl-*.so
+   fun:dlopen*
+}
+
diff -Nrup a/strings/strmake.c b/strings/strmake.c
--- a/strings/strmake.c	2007-12-17 01:43:18 -08:00
+++ b/strings/strmake.c	2008-02-19 13:46:50 -08:00
@@ -41,9 +41,9 @@ char *strmake(register char *dst, regist
     write a character rather than '\0' as this makes spotting these
     problems in the results easier.
   */
-  uint n= strlen(src) + 1;
-  if (n <= length)
-    memset(dst + n, (int) 'Z', length - n + 1);
+  uint n= 0;
+  while (n < length && src[n++]);
+  memset(dst + n, (int) 'Z', length - n + 1);
 #endif
 
   while (length--)
Thread
bk commit into 5.1 tree (acurtis:1.2524)antony19 Feb