MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:tim Date:February 15 2008 5:48pm
Subject:bk commit into 5.0 tree (tsmith:1.2578) BUG#28555
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of tsmith.  When tsmith does a push these changes
will be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository

ChangeSet@stripped, 2008-02-15 10:48:41-07:00, tsmith@stripped +1 -0
  Bug #28555  Upgrading MySQL Fails to shut down old server and kills socket file
  Check for an existing MySQL server package from a different vendor or
  major MySQL version.  In such a case, refuse to install the server and
  recommend how to safely remove the old packages before installing the
  new ones.

  support-files/, 2008-02-15 10:48:39-07:00, tsmith@stripped +67 -1
    Add to the %pre server scriptlet checks to ensure that we're not
    upgrading from another vendor's package, or that this is not a
    major version upgrade.  If an automatic upgrade isn't safe, print
    basic instructions on how to do a manual upgrade, and bail out.

diff -Nrup a/support-files/ b/support-files/
--- a/support-files/	2007-11-16 09:36:11 -07:00
+++ b/support-files/	2008-02-15 10:48:39 -07:00
@@ -15,6 +15,7 @@
 # MA  02110-1301  USA.
 %define mysql_version   @VERSION@
+%define mysql_vendor    MySQL AB
 # use "rpmbuild --with static" or "rpm --define '_with_static 1'" (for RPM 3.x)
 # to enable static linking (off by default)
@@ -69,7 +70,7 @@ License:	%{license}
 Packager:	MySQL Production Engineering Team <build@stripped>
-Vendor:		MySQL AB
+Vendor:		%{mysql_vendor}
 Provides:	msqlormysql MySQL-server mysql
 BuildRequires: ncurses-devel
 Obsoletes:	mysql
@@ -420,6 +421,71 @@ touch $RBR%{_sysconfdir}/my.cnf
 touch $RBR%{_sysconfdir}/mysqlmanager.passwd
 %pre server
+# Check if we can safely upgrade.  An upgrade is only safe if it's from one
+# of our RPMs in the same version family.
+installed=`rpm -q --whatprovides mysql-server 2> /dev/null`
+if [ $? -eq 0 -a -n "$installed" ]; then
+  vendor=`rpm -q --queryformat='%{VENDOR}' "$installed" 2>&1`
+  version=`rpm -q --queryformat='%{VERSION}' "$installed" 2>&1`
+  myvendor='%{mysql_vendor}'
+  myversion='%{mysql_version}'
+  old_family=`echo $version   | sed -n -e 's,^\([1-9][0-9]*\.[0-9][0-9]*\)\..*$,\1,p'`
+  new_family=`echo $myversion | sed -n -e 's,^\([1-9][0-9]*\.[0-9][0-9]*\)\..*$,\1,p'`
+  [ -z "$old_family" ] && old_family="<unrecognized version $version>"
+  [ -z "$new_family" ] && new_family="<bad package specification: version $myversion>"
+  error_text=
+  if [ "$vendor" != "$myvendor" ]; then
+    error_text="$error_text
+The current MySQL server package is provided by a different
+vendor ($vendor) than $myvendor.  Some files may be installed
+to different locations, including log files and the service
+startup script in %{_sysconfdir}/init.d/.
+  fi
+  if [ "$old_family" != "$new_family" ]; then
+    error_text="$error_text
+Upgrading directly from MySQL $old_family to MySQL $new_family may not
+be safe in all cases.  Some data may need to be dumped to a textual
+backup and restored manually.  It is important to review the MySQL
+manual's Upgrading section for version-specific incompatibilities.
+  fi
+  if [ -n "$error_text" ]; then
+    cat <<HERE >&2
+A MySQL server package ($installed) is installed.
+A manual upgrade is required.
+- Ensure that you have a complete, working backup of your data and my.cnf
+  files
+- Shut down the MySQL server cleanly
+- Remove the existing MySQL packages.  Usually this command will
+  list the packages you should remove:
+  rpm -qa | grep -i '^mysql-'
+  You may choose to use 'rpm --nodeps -ev <package-name>' to remove
+  the package which contains the mysqlclient shared library.  The
+  library will be reinstalled by the MySQL-shared-compat package.
+- Install the new MySQL packages supplied by $myvendor
+- Ensure that the MySQL server is started
+- Run the 'mysql_upgrade' program
+This is a brief description of the upgrade process.  Important details
+can be found in the MySQL manual, in the Upgrading section.
+    exit 1
+  fi
 # Shut down a previously installed server first
 if test -x %{_sysconfdir}/init.d/mysql
bk commit into 5.0 tree (tsmith:1.2578) BUG#28555tim15 Feb