MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Andrei Elkin Date:December 21 2007 8:14am
Subject:bk commit into 5.0 tree (aelkin:1.2560) BUG#31359
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of elkin. When elkin does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-12-21 10:13:54+02:00, aelkin@stripped +1 -0
  Bug #31359  change_master sets group_master_log_pos twice, 
              ignores future_group_master_log_p
  
  There was a redundant assignement. However, that's the only artifact.
  Wrt to future_group_master_log_position, there is no issue.
  The counter is supposed to be set at Log_event::exec_event().
  It's used only by Innodb for recovery purposes.

  sql/sql_repl.cc@stripped, 2007-12-21 10:13:51+02:00, aelkin@stripped +1 -3
    removing a redundant line which arrived with the revision 1.102.1.7.

diff -Nrup a/sql/sql_repl.cc b/sql/sql_repl.cc
--- a/sql/sql_repl.cc	2007-10-03 12:57:12 +03:00
+++ b/sql/sql_repl.cc	2007-12-21 10:13:51 +02:00
@@ -1229,9 +1229,6 @@ bool change_master(THD* thd, MASTER_INFO
       DBUG_RETURN(TRUE);
     }
   }
-  mi->rli.group_master_log_pos = mi->master_log_pos;
-  DBUG_PRINT("info", ("master_log_pos: %lu", (ulong) mi->master_log_pos));
-
   /*
     Coordinates in rli were spoilt by the 'if (need_relay_log_purge)' block,
     so restore them to good values. If we left them to ''/0, that would work;
@@ -1243,6 +1240,7 @@ bool change_master(THD* thd, MASTER_INFO
     That's why we always save good coords in rli.
   */
   mi->rli.group_master_log_pos= mi->master_log_pos;
+  DBUG_PRINT("info", ("master_log_pos: %lu", (ulong) mi->master_log_pos));
   strmake(mi->rli.group_master_log_name,mi->master_log_name,
 	  sizeof(mi->rli.group_master_log_name)-1);
 
Thread
bk commit into 5.0 tree (aelkin:1.2560) BUG#31359Andrei Elkin21 Dec
  • Re: bk commit into 5.0 tree (aelkin:1.2560) BUG#31359Sven Sandberg21 Dec