MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Konstantin Osipov Date:December 12 2007 12:13pm
Subject:Re: bk commit into 6.0 tree (antony:1.2699) WL#3771
View as plain text  
* antony@stripped <antony@stripped> [07/12/12 12:47]:
> ChangeSet@stripped, 2007-12-12 01:36:30-08:00, antony@stripped +24 -0
>   WL#3771 - Plugable Audit Interface
>     Second commit for review.
>     Have run default tests with/without plugin:
>     mysql-test-run.pl --mysqld=--plugin-dir=<path to plugin>
>                       --mysqld=--plugin-load=adt_null.so

If I remember correctly the arch. board meeting, the decision was
to embed the audit hook into my_message_sql.

Why is it being embedded into net_send_error?

If you decided to sacrifice modularity, mix up server components
:), and add auditing hooks into error handling, at least do it please
inside error handling, not inside network protocol.

net_send_error, for that matter, is re-defined in the embedded
library.

It was also mentioned at the arch. board that auditing needs to be
inside my_message_sql to work even if there is a continue handler
for an sqlexception.

Last, for the sake of ease of future merges, you might want to look
at the runtime this afternoon (after the first patch of 12713 is
pushed.
It changes the field you're working on quite a bit.

-- 
-- Konstantin Osipov              Software Developer, Moscow, Russia
-- MySQL AB, www.mysql.com   The best DATABASE COMPANY in the GALAXY
Thread
bk commit into 6.0 tree (antony:1.2699) WL#3771antony12 Dec
  • Re: bk commit into 6.0 tree (antony:1.2699) WL#3771Konstantin Osipov12 Dec