MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Ingo Strüwing Date:December 6 2007 3:49pm
Subject:Re: bk commit into 5.1 tree (svoj:1.2677) BUG#32817
View as plain text  
Hi Sergey,

Sergey Vojtovich, 06.12.2007 16:19:
...
> On Thu, Dec 06, 2007 at 03:46:44PM +0100, Ingo Strüwing wrote:
...
>> Sergey Vojtovich, 06.12.2007 14:40:
...
>>> +--error 1178
>> I only ask you to replace 1178 by ER_CHECK_NOT_IMPLEMENTED at these places.

> I use error codes instead of error names intentionally.

I have been asked for such conversions myself a couple of times.

http://forge.mysql.com/wiki/How_to_Create_Good_Tests says "Use error
names instead of error numbers whenever possible".

But I do not insist in it.

>   There is a rule that
> we must _append_ error messages at the end of errmsg.txt. Per my
> understanding error codes are auto-generated, so if one inserts another
> error message, e.g. before ER_CHECK_NOT_IMPLEMENTED, a test case fails. If
> we would use error names instead, it'll succeed.
> 
> OTOH I'm not really sure if this initiative is desirable.

I have never heared of it. Anyway, if we want to assert that error
numbers do not change, we better have one dedicated test case that
provokes a number of errors, including one of the current last errors,
which is reasonably simple to provoke.

Regards
Ingo
-- 
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Dachauer Str. 37, D-80335 München
Geschäftsführer: Kaj Arnö - HRB München 162140
Thread
bk commit into 5.1 tree (svoj:1.2677) BUG#32817Sergey Vojtovich6 Dec
  • Re: bk commit into 5.1 tree (svoj:1.2677) BUG#32817Ingo Strüwing6 Dec
Re: bk commit into 5.1 tree (svoj:1.2677) BUG#32817Ingo Strüwing6 Dec