List:Commits« Previous MessageNext Message »
From:Guilhem Bichot Date:November 20 2007 9:25am
Subject:bk commit into 5.0 tree (guilhem:1.2561) BUG#27850
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of guilhem. When guilhem does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-11-20 10:25:07+01:00, guilhem@stripped +1 -0
  BUG#27850 "mysqldump --single-transaction does not work if TRUNCATE/DROP/RENAME/ALTER":
  this has already been closed by a note in the manual, now we
  complete this by a note in "mysqldump --help"

  client/mysqldump.c@stripped, 2007-11-20 10:25:04+01:00, guilhem@stripped +6 -2
    mention, in "mysqldump --help", of limitations reported as BUG#27850
    "mysqldump --single-transaction does not work if TRUNCATE/DROP/RENAME/ALTER"
    The new text is inspired from what the "mysqldump" section of the
    manual now says about --single-transaction:
    http://dev.mysql.com/doc/refman/5.1/en/mysqldump.html

diff -Nrup a/client/mysqldump.c b/client/mysqldump.c
--- a/client/mysqldump.c	2007-10-04 08:42:32 +02:00
+++ b/client/mysqldump.c	2007-11-20 10:25:04 +01:00
@@ -404,8 +404,12 @@ static struct my_option my_long_options[
    "Creates a consistent snapshot by dumping all tables in a single "
    "transaction. Works ONLY for tables stored in storage engines which "
    "support multiversioning (currently only InnoDB does); the dump is NOT "
-   "guaranteed to be consistent for other storage engines. Option "
-   "automatically turns off --lock-tables.",
+   "guaranteed to be consistent for other storage engines. "
+   "While a --single-transaction dump is in process, to ensure a valid "
+   "dump file (correct table contents and binary log position), no other "
+   "connection should use the following statements: ALTER TABLE, DROP "
+   "TABLE, RENAME TABLE, TRUNCATE TABLE, as consistent snapshot is not "
+   "isolated from them. Option automatically turns off --lock-tables.",
    (gptr*) &opt_single_transaction, (gptr*) &opt_single_transaction, 0,
    GET_BOOL, NO_ARG,  0, 0, 0, 0, 0, 0},
   {"skip-opt", OPT_SKIP_OPTIMIZATION,
Thread
bk commit into 5.0 tree (guilhem:1.2561) BUG#27850Guilhem Bichot20 Nov