MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:holyfoot Date:November 10 2007 12:54pm
Subject:bk commit into 4.1 tree (holyfoot:1.2688) BUG#32063
View as plain text  
Below is the list of changes that have just been committed into a local
4.1 repository of hf. When hf does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-11-10 16:54:25+04:00, holyfoot@stripped +1 -0
  Bug #32063 "create table like" works case-significant only in "embedded" server (libmysqld)
  
  in mysql_creata_like_table() we 'downcase' the complete path to the
  .frm file. It works fine in standalone case as there usually
  we only have './' as a path to the datahome, but doesn't work in
  the embedded server where we add the real path there, so if a
  directory has uppercase letters in it's name, it won't be found.
  
  Fixed by 'downcasing' only database/table pair.

  sql/sql_table.cc@stripped, 2007-11-10 16:54:24+04:00, holyfoot@stripped +4 -4
    Bug #32063 "create table like" works case-significant only in "embedded" server (libmysqld)
    
    do not lowercase the database directory

diff -Nrup a/sql/sql_table.cc b/sql/sql_table.cc
--- a/sql/sql_table.cc	2007-01-15 14:03:18 +04:00
+++ b/sql/sql_table.cc	2007-11-10 16:54:24 +04:00
@@ -2429,12 +2429,12 @@ int mysql_create_like_table(THD* thd, TA
     strxmov(src_path, (*tmp_table)->path, reg_ext, NullS);
   else
   {
-    strxmov(src_path, mysql_data_home, "/", src_db, "/", src_table,
-	    reg_ext, NullS);
+    char *tablename_pos= strxmov(src_path, mysql_data_home, "/", NullS);
+    strxmov(tablename_pos, src_db, "/", src_table, reg_ext, NullS);
+    if (lower_case_table_names)
+      my_casedn_str(files_charset_info, tablename_pos);
     /* Resolve symlinks (for windows) */
     fn_format(src_path, src_path, "", "", MYF(MY_UNPACK_FILENAME));
-    if (lower_case_table_names)
-      my_casedn_str(files_charset_info, src_path);
     if (access(src_path, F_OK))
     {
       my_error(ER_BAD_TABLE_ERROR, MYF(0), src_table);
Thread
bk commit into 4.1 tree (holyfoot:1.2688) BUG#32063holyfoot10 Nov
  • Re: bk commit into 4.1 tree (holyfoot:1.2688) BUG#32063Sergei Golubchik19 Nov