Hi Mattias,
thanks for the review.
Mattias Jonsson, 09.11.2007 18:15:
> OK to push, the only comment I have is a proposal for a new error
> message, since it might be hard to understand.
...
> Ingo Struewing wrote:
...
>> +CREATE TABLE t1 (c1 INT) ENGINE=MyISAM PARTITION BY HASH(c1)
>> PARTITIONS 1;
>> +INSERT DELAYED INTO t1 VALUES (1);
>> +ERROR HY000: Table storage engine for 't1' doesn't have this option
>
> what option? (might an inexperienced mysql user think.)
> But I believe this a what other storage engines say, so never mind.
In this case it is the 'DELAYED' option. The manual says that it can be
used with MyISAM, MEMORY, and ARCHIVE only.
This error message is used for several options that are not supported by
all handlers. I agree that it would be great to have dedicated messages
for every combination of cases, but this would not be a small task.
Regards
Ingo
--
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Dachauer Str. 37, D-80335 München
Geschäftsführer: Kaj Arnö - HRB München 162140
