MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:kpettersson Date:October 15 2007 9:48am
Subject:bk commit into 5.0 tree (thek:1.2538) BUG#31594
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of thek. When thek does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-10-15 11:48:38+02:00, thek@adventure.(none) +1 -0
  Bug #31594 Query Cache fail to register tables because of trivial coding misstake.
  
  In function register_all_tables there is a check for success on the call to
  register_tables_from_list. This function has failed if it returns 0 (representing the
  number of the next table entry position).

  sql/sql_cache.cc@stripped, 2007-10-15 11:48:34+02:00, thek@adventure.(none) +1 -1
    If register_tables_from_list returns 0 it has failed, not the other way around.

diff -Nrup a/sql/sql_cache.cc b/sql/sql_cache.cc
--- a/sql/sql_cache.cc	2007-09-03 13:46:07 +02:00
+++ b/sql/sql_cache.cc	2007-10-15 11:48:34 +02:00
@@ -2501,7 +2501,7 @@ my_bool Query_cache::register_all_tables
 
   n= register_tables_from_list(tables_used, 0, block_table);
 
-  if (n)
+  if (n==0)
   {
     DBUG_PRINT("qcache", ("failed at table %d", (int) n));
     /* Unlink the tables we allocated above */
Thread
bk commit into 5.0 tree (thek:1.2538) BUG#31594kpettersson15 Oct
  • Re: bk commit into 5.0 tree (thek:1.2538) BUG#31594Marc Alff25 Oct