MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:Joerg Bruehe Date:October 11 2007 10:28am
Subject:Re: bk commit into 5.0 tree (kaa:1.2527) BUG#31254
View as plain text  
Hi Alexey, all !


Alexey Kopytov wrote:
> Below is the list of changes that have just been committed into a local
> 5.0 repository of kaa. When kaa does a push these changes will
> be propagated to the main repository and, within 24 hours after the
> push, to the public repository.
> For information on how to access the public repository
> see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html
> 
> ChangeSet@stripped, 2007-10-11 13:32:57+04:00, kaa@polly.(none) +2 -0
>   Fix for bug #31254: "Max_data_length" truncated / reported wrong (compiler issue
> ?)
>   
>   Reverted large-file changes from the fix for bug10776. We need to define
> _LARGE_FILES on AIX to have support for files > 2 GB. Since _LARGE_FILE_API is
> incompatible with _LARGE_FILES and may be automatically included, we also need a
> workaround to avoid this conflict.
> 
>   config/ac-macros/large_file.m4@stripped, 2007-10-11 13:32:53+04:00, kaa@polly.(none) +8
> -2
>     Reverted large-file changes from the fix for bug10776. We need to define
> _LARGE_FILES on AIX to have support for files > 2 GB.
> 
>   include/my_global.h@stripped, 2007-10-11 13:32:53+04:00, kaa@polly.(none) +5 -0
>     _LARGE_FILE_API is defined in standards.h that is automatically included by at
> least some C++ compilers on AIX. Since it is also incompatible with _LARGE_FILES which is
> required for POSIX IO calls to be largefile-safe, the only workaround is to explicitely
> #undef _LARGE_FILE_API.
> 
> diff -Nrup a/config/ac-macros/large_file.m4 b/config/ac-macros/large_file.m4
> --- a/config/ac-macros/large_file.m4	2007-08-01 06:56:48 +04:00
> +++ b/config/ac-macros/large_file.m4	2007-10-11 13:32:53 +04:00
> @@ -128,8 +128,14 @@ AC_DEFUN([MYSQL_SYS_LARGEFILE],
>  	  ac_cv_sys_largefile_source=1 ;;
>  	esac])
>  
> -     # AIX 4.2 and later -- do nothing, include standards.h instead.
> -     # this goes for both GNU and IBM C and C++ compilers.
> +     AC_SYS_LARGEFILE_MACRO_VALUE(_LARGE_FILES,
> +       ac_cv_sys_large_files,
> +       [Large files support on AIX-style hosts.],
> +       [case "$host_os" in
> +       # AIX 4.2 and later
> +       aix4.[2-9]* | aix4.1[0-9]* | aix[5-9].* | aix[1-9][0-9]*)
> +         ac_cv_sys_large_files=1 ;;
> +       esac])
 >     fi
 >    ])
 >

While I understand the approach of reverting the change that caused it, 
I am not happy with that list of AIX version patterns - it raises the 
impression we were supporting these platforms.

As this fix deals with MySQL 5.0 and up, the only AIX versions we 
support are AIX 5.2 and up. (With MySQL 4.1, we still support AIX 4.3.)

IMO, the list should read either (because we build there)

 > +       [case "$host_os" in
 > +       # AIX 5.2 and later
 > +       aix5.[2-9]* | aix[6-9].* )
 > +         ac_cv_sys_large_files=1 ;;
 > +       esac])

or (a bit easier, and hopefully correct - all AIX 5 should be similar)

 > +       [case "$host_os" in
 > +       # AIX 5 and later
 > +       aix[5-9].* )
 > +         ac_cv_sys_large_files=1 ;;
 > +       esac])

or (for simplicity, without claiming support)

 > +       [case "$host_os" in
 > +       # any AIX  -  but tested only on 5.2 and up
 > +       aix* )
 > +         ac_cv_sys_large_files=1 ;;
 > +       esac])

The very elaborate list (of the original code, which you propose to 
restore) raises the impression of being target at exactly those 
versions, and IMO that is wrong.


Regards,
Jörg

-- 
Joerg Bruehe, Senior Production Engineer
MySQL AB, www.mysql.com
Office:  (+49 30) 417 01 487     VoIP: 4464@stripped

Thread
bk commit into 5.0 tree (kaa:1.2527) BUG#31254Alexey Kopytov11 Oct
  • Re: bk commit into 5.0 tree (kaa:1.2527) BUG#31254Joerg Bruehe11 Oct
    • Re: bk commit into 5.0 tree (kaa:1.2527) BUG#31254Alexey Kopytov11 Oct
      • Re: bk commit into 5.0 tree (kaa:1.2527) BUG#31254Joerg Bruehe11 Oct
  • Re: bk commit into 5.0 tree (kaa:1.2527) BUG#31254Ingo Strüwing12 Oct
    • Re: bk commit into 5.0 tree (kaa:1.2527) BUG#31254Alexey Kopytov12 Oct