MySQL Lists are EOL. Please join:

List:Commits« Previous MessageNext Message »
From:gluh Date:March 3 2006 11:29am
Subject:bk commit into 5.0 tree (gluh:1.2099) BUG#17826
View as plain text  
Below is the list of changes that have just been committed into a local
5.0 repository of gluh. When gluh does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet
  1.2099 06/03/03 15:29:39 gluh@stripped +3 -0
  Fix for bug#17826 'type_decimal' fails with ps-protocol
   removed unnecessary calculation of cache value 
   otherwise Join::preapre tries to calculate 
   undefined values(filed values)

  sql/item_cmpfunc.cc
    1.193 06/03/03 15:28:16 gluh@stripped +0 -6
    Fix for bug#17826 'type_decimal' fails with ps-protocol
     removed unnecessary calculation of cache value 
     otherwise Join::preapre tries to calculate 
     undefined values(filed values)

  mysql-test/t/type_decimal.test
    1.31 06/03/03 15:28:16 gluh@stripped +8 -0
    Fix for bug#17826 'type_decimal' fails with ps-protocol
     test case, this test case reproduce the same bug but without PS protocol

  mysql-test/r/type_decimal.result
    1.41 06/03/03 15:28:16 gluh@stripped +7 -0
    Fix for bug#17826 'type_decimal' fails with ps-protocol
     test case, this test case reproduce the same bug but without PS protocol

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	gluh
# Host:	eagle.intranet.mysql.r18.ru
# Root:	/home/gluh/MySQL/Merge/mysql-5.0-release

--- 1.192/sql/item_cmpfunc.cc	Wed Mar  1 15:48:52 2006
+++ 1.193/sql/item_cmpfunc.cc	Fri Mar  3 15:28:16 2006
@@ -698,12 +698,6 @@ bool Item_in_optimizer::fix_left(THD *th
     return 1;
 
   cache->setup(args[0]);
-  /*
-    If it is preparation PS only then we do not know values of parameters =>
-    cant't get there values and do not need that values.
-  */
-  if (!thd->stmt_arena->is_stmt_prepare())
-    cache->store(args[0]);
   if (cache->cols() == 1)
   {
     if ((used_tables_cache= args[0]->used_tables()))

--- 1.40/mysql-test/r/type_decimal.result	Tue Jan 17 22:10:41 2006
+++ 1.41/mysql-test/r/type_decimal.result	Fri Mar  3 15:28:16 2006
@@ -772,3 +772,10 @@ productid	zlevelprice
 003trans	39.98
 004trans	31.18
 drop table t1, t2;
+create table t1 (f1 decimal(5));
+insert into t1 values (40);
+flush tables;
+select f1 from t1 where f1 in (select f1 from t1);
+f1
+40
+drop table t1;

--- 1.30/mysql-test/t/type_decimal.test	Tue Jan 17 22:10:41 2006
+++ 1.31/mysql-test/t/type_decimal.test	Fri Mar  3 15:28:16 2006
@@ -377,3 +377,11 @@ insert INTO t2 SELECT * FROM t1;
 select * from t2; 
 drop table t1, t2;
 
+#
+# Bug #17826 'type_decimal' fails with ps-protocol
+#
+create table t1 (f1 decimal(5));
+insert into t1 values (40);
+flush tables;
+select f1 from t1 where f1 in (select f1 from t1);
+drop table t1;
Thread
bk commit into 5.0 tree (gluh:1.2099) BUG#17826gluh3 Mar